Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: runtime/lib/print_patch.dart

Issue 10887024: Move print to corelib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Get rid of more builtin importing that is no longer needed. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5
6 typedef void _PrintClosure(Object obj);
7
8 patch class PrintImplementation {
9 /* patch */ static void print(Object obj) {
10 _printClosure(obj.toString());
11 }
12
13 static void _print(Object obj) native "PrintImplementation_printString";
Ivan Posva 2012/08/30 00:32:13 This closure belongs into the builtin library.
Mads Ager (google) 2012/08/30 06:59:17 Got it. I can move it back to builtin and do the p
14
15 // _printClosure can be overwritten by the embedder to supply a different
16 // print implementation.
17 static _PrintClosure _printClosure = _print;
Ivan Posva 2012/08/30 00:32:13 And we should initialize the _printClosure with so
Mads Ager (google) 2012/08/30 06:59:17 We can do that. I actually liked the fact that emb
18 }
OLDNEW
« runtime/lib/print.cc ('K') | « runtime/lib/print.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698