runtime/lib/print.cc - Issue 10887024: Move print to corelib.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/print.cc

Issue 10887024: Move print to corelib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Get rid of more builtin importing that is no longer needed. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "vm/native_arguments.h"	5 #include "vm/bootstrap_natives.h"
	Ivan Posva 2012/08/30 00:32:13 Again this change file makes no sense to me. Again this change file makes no sense to me. Mads Ager (google) 2012/08/30 06:59:17 Diff tools playing with the change. New file. Show quoted text On 2012/08/30 00:32:13, Ivan Posva wrote: > Again this change file makes no sense to me. Diff tools playing with the change. New file.
6

7 #include "platform/assert.h"

8 #include "vm/object.h"

9	6

10 namespace dart {	7 namespace dart {

11	8

12 void NativeArguments::SetReturn(const Object& value) const {	9 DEFINE_NATIVE_ENTRY(PrintImplementation_printString, 1) {

13 *retval_ = value.raw();	10 GET_NATIVE_ARGUMENT(String, str, arguments->At(0));
	Ivan Posva 2012/08/30 00:32:13 The core VM is not allowed to write to stdout. Thi The core VM is not allowed to write to stdout. This is the job of the embedder and thus should go somewhere else. Mads Ager (google) 2012/08/30 06:59:17 That makes sense. I'll move this back to builtins Show quoted text On 2012/08/30 00:32:13, Ivan Posva wrote: > The core VM is not allowed to write to stdout. This is the job of the embedder > and thus should go somewhere else. That makes sense. I'll move this back to builtins and patch it in as in Dartium.
	11 const char* cstring = str.ToCString();

	12 fputs(cstring, stdout);

	13 fputc('\n', stdout);
	Ivan Posva 2012/08/30 00:32:13 By having two calls you will be hit with concurren By having two calls you will be hit with concurrent prints messing with your line ending addition. What is wrong with fprintf(stdout, "%s\n", cstring)? Mads Ager (google) 2012/08/30 06:59:17 Nothing wrong with that. I was following what was Show quoted text On 2012/08/30 00:32:13, Ivan Posva wrote: > By having two calls you will be hit with concurrent prints messing with your > line ending addition. What is wrong with fprintf(stdout, "%s\n", cstring)? Nothing wrong with that. I was following what was in builtin. I have reinstated the builtin code.
	14 fflush(stdout);

14 }	15 }

15	16

16 } // namespace dart	17 } // namespace dart

OLD	NEW

« corelib/src/print.dart ('K') | « runtime/lib/lib_impl_sources.gypi ('k') | runtime/lib/print_patch.dart » ('j') | runtime/lib/print_patch.dart » ('J')