Issue 10835034: Fix an off-by-one error in the stack frame iteration.

Issue 10835034: Fix an off-by-one error in the stack frame iteration. (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix an off-by-one error in the stack frame iteration. When using a stackmap, we mapped stackmap index 0 to the code slot in the frame. This code is still unused, but judging from the test the intent is to map index 0 to the first local slot in the frame. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10013

Patch Set 1 #

Total comments: 3

Patch Set 2 : Renaming per review comments. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -54 lines)			Patch
M	runtime/vm/bitmap.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bitmap.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/code_descriptors_test.cc	View	1	7 chunks	+19 lines, -11 lines	0 comments	Download
M	runtime/vm/object.h	View	1	3 chunks	+13 lines, -13 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	4 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stack_frame.cc	View	1	2 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10835034/diff/1/runtime/vm/stack_frame.cc File runtime/vm/stack_frame.cc (right): https://chromiumcodereview.appspot.com/10835034/diff/1/runtime/vm/stack_frame.cc#newcode65 runtime/vm/stack_frame.cc:65: intptr_t bit_index = map.MinimumBitOffset(); s/MinimumBitOffset/MinimumBitIndex/ https://chromiumcodereview.appspot.com/10835034/diff/1/runtime/vm/stack_frame.cc#newcode84 runtime/vm/stack_frame.cc:84: RawObject** ...

8 years, 4 months ago (2012-07-30 13:00:38 UTC) #2

Kevin Millikin (Google)

8 years, 4 months ago (2012-07-30 13:41:03 UTC) #3

https://chromiumcodereview.appspot.com/10835034/diff/1/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (right):

https://chromiumcodereview.appspot.com/10835034/diff/1/runtime/vm/stack_frame...
runtime/vm/stack_frame.cc:65: intptr_t bit_index = map.MinimumBitOffset();
On 2012/07/30 13:00:38, Vyacheslav Egorov (Google) wrote:
> s/MinimumBitOffset/MinimumBitIndex/

OK, but that caused a cascade of offset -> index renames.

Expand Messages | Collapse Messages