Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Side by Side Diff: runtime/vm/raw_object.h

Issue 10835034: Fix an off-by-one error in the stack frame iteration. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Renaming per review comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_RAW_OBJECT_H_ 5 #ifndef VM_RAW_OBJECT_H_
6 #define VM_RAW_OBJECT_H_ 6 #define VM_RAW_OBJECT_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/globals.h" 9 #include "vm/globals.h"
10 #include "vm/token.h" 10 #include "vm/token.h"
(...skipping 771 matching lines...) Expand 10 before | Expand all | Expand 10 after
782 782
783 RawObject** from() { 783 RawObject** from() {
784 return reinterpret_cast<RawObject**>(&ptr()->code_); 784 return reinterpret_cast<RawObject**>(&ptr()->code_);
785 } 785 }
786 RawCode* code_; // Code object corresponding to the frame described. 786 RawCode* code_; // Code object corresponding to the frame described.
787 RawSmi* bitmap_size_in_bytes_; // Size of the bit map in bytes. 787 RawSmi* bitmap_size_in_bytes_; // Size of the bit map in bytes.
788 RawObject** to() { 788 RawObject** to() {
789 return reinterpret_cast<RawObject**>(&ptr()->bitmap_size_in_bytes_); 789 return reinterpret_cast<RawObject**>(&ptr()->bitmap_size_in_bytes_);
790 } 790 }
791 uword pc_; // PC corresponding to this stack map representation. 791 uword pc_; // PC corresponding to this stack map representation.
792 intptr_t min_set_bit_offset_; // Minimum bit offset which is set. 792 intptr_t min_set_bit_index_; // Minimum bit offset which is set.
793 intptr_t max_set_bit_offset_; // Maximum bit offset which is set. 793 intptr_t max_set_bit_index_; // Maximum bit offset which is set.
794 794
795 // Variable length data follows here (bitmap of the stack layout). 795 // Variable length data follows here (bitmap of the stack layout).
796 uint8_t data_[0]; 796 uint8_t data_[0];
797 }; 797 };
798 798
799 799
800 class RawLocalVarDescriptors : public RawObject { 800 class RawLocalVarDescriptors : public RawObject {
801 public: 801 public:
802 enum VarInfoKind { 802 enum VarInfoKind {
803 kStackVar = 1, 803 kStackVar = 1,
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
1517 kExternalUint64Array == kByteArray + 18 && 1517 kExternalUint64Array == kByteArray + 18 &&
1518 kExternalFloat32Array == kByteArray + 19 && 1518 kExternalFloat32Array == kByteArray + 19 &&
1519 kExternalFloat64Array == kByteArray + 20 && 1519 kExternalFloat64Array == kByteArray + 20 &&
1520 kClosure == kByteArray + 21); 1520 kClosure == kByteArray + 21);
1521 return (index >= kByteArray && index <= kClosure); 1521 return (index >= kByteArray && index <= kClosure);
1522 } 1522 }
1523 1523
1524 } // namespace dart 1524 } // namespace dart
1525 1525
1526 #endif // VM_RAW_OBJECT_H_ 1526 #endif // VM_RAW_OBJECT_H_
OLDNEW
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698