Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2102)

Unified Diff: runtime/vm/bitmap.cc

Issue 10835034: Fix an off-by-one error in the stack frame iteration. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Renaming per review comments. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/bitmap.h ('k') | runtime/vm/code_descriptors_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/bitmap.cc
diff --git a/runtime/vm/bitmap.cc b/runtime/vm/bitmap.cc
index 1d08b265f66aeebe5d2367f59f74b808c57dd8e2..4a1d469741a16f16717149cdad3d964dc05488a8 100644
--- a/runtime/vm/bitmap.cc
+++ b/runtime/vm/bitmap.cc
@@ -62,9 +62,9 @@ void BitmapBuilder::SetRange(intptr_t min, intptr_t max, bool value) {
}
-void BitmapBuilder::SetBits(const Stackmap& bitmap) {
- intptr_t min = bitmap.MinimumBitOffset();
- intptr_t max = bitmap.MaximumBitOffset();
+void BitmapBuilder::SetBits(const Stackmap& stackmap) {
+ intptr_t min = stackmap.MinimumBitIndex();
+ intptr_t max = stackmap.MaximumBitIndex();
if (min == Stackmap::kNoMinimum || max == Stackmap::kNoMaximum) {
return;
}
@@ -72,7 +72,7 @@ void BitmapBuilder::SetBits(const Stackmap& bitmap) {
Set(i, false);
}
for (intptr_t i = min; i <= max; i++) {
- Set(i, bitmap.IsObject(i));
+ Set(i, stackmap.IsObject(i));
}
intptr_t bound = SizeInBits();
for (intptr_t i = (max + 1); i < bound; i++) {
« no previous file with comments | « runtime/vm/bitmap.h ('k') | runtime/vm/code_descriptors_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698