Store pointer instead of reference to LocalVariable in ast and flow graph.

Store pointer instead of reference to LocalVariable in ast and flow graph.
Address comments of already committed r10203.
Committed: https://code.google.com/p/dart/source/detail?r=10321

[hausner, 2012-08-03 15:43:37]

LGTM.

[Ivan Posva, 2012-08-03 20:10:26]

I would like to reduce the amount of changes needed following this. Please see
the suggestion I have added.

-Ivan

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h
File runtime/vm/ast.h (right):

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:933: ASSERT(local_ != NULL);
local_ = *local;

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:944: const LocalVariable* local() const { return local_; }
Then this change is not needed, which is causing you a massive amount of changes
to follow.

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:959: const LocalVariable* local_;
ditto.

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:1663: 
Why here, but not on line 1634?

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/object.h#ne...
runtime/vm/object.h:1361: RawAbstractType* result_type() const { return
raw_ptr()->result_type_; }
This is a completely unrelated change. Please remove.

[regis, 2012-08-06 22:31:49]

Thanks!

Please, have another look.

-- Regis

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h
File runtime/vm/ast.h (right):

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:933: ASSERT(local_ != NULL);
On 2012/08/03 20:10:26, Ivan Posva wrote:
> local_ = *local;

This is actually not possible, because of
DISALLOW_COPY_AND_ASSIGN(LocalVariable).

I can either remove this restriction, or assign via the initializer, but this
would not prevent dereferencing of NULL:


  LoadLocalNode(intptr_t token_pos, const LocalVariable* local)
      : AstNode(token_pos), local_(*local), pseudo_(NULL) {
    ASSERT(local != NULL);
  }

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:944: const LocalVariable* local() const { return local_; }
On 2012/08/03 20:10:26, Ivan Posva wrote:
> Then this change is not needed, which is causing you a massive amount of
changes
> to follow.

Done.

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:959: const LocalVariable* local_;
On 2012/08/03 20:10:26, Ivan Posva wrote:
> ditto.

Done.

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/ast.h#newco...
runtime/vm/ast.h:1663: 
On 2012/08/03 20:10:26, Ivan Posva wrote:
> Why here, but not on line 1634?

Added new line after 1634.

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/10832126/diff/1/runtime/vm/object.h#ne...
runtime/vm/object.h:1361: RawAbstractType* result_type() const { return
raw_ptr()->result_type_; }
On 2012/08/03 20:10:26, Ivan Posva wrote:
> This is a completely unrelated change. Please remove.

As the title of this cl states, this is a follow up to revision 10203 to address
late comments by Matthias.

[Ivan Posva, 2012-08-06 23:11:16]

LGTM -ip