Store pointer instead of reference to LocalVariable in ast and flow graph.

runtime/vm/ast.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_AST_H_
 #define VM_AST_H_
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
@@ skipping 81 matching lines @@
 
 class AstNode : public ZoneAllocated {
  public:
   static const int kNoId = -1;
 
   explicit AstNode(intptr_t token_pos)
       : token_pos_(token_pos),
         id_(GetNextId()),
         ic_data_(ICData::ZoneHandle()),
         info_(NULL) {
-    ASSERT(token_pos >= 0);
+    ASSERT(token_pos_ >= 0);
   }
 
   intptr_t token_pos() const { return token_pos_; }
 
 
   const ICData& ic_data() const { return ic_data_; }
   void set_ic_data(const ICData& value) {
     ic_data_ = value.raw();
   }
 
@@ skipping 349 matching lines @@
  public:
   // Return from a void function returns the null object.
   explicit ReturnNode(intptr_t token_pos)
       : AstNode(token_pos),
         value_(new LiteralNode(token_pos, Instance::ZoneHandle())),
         inlined_finally_list_() { }
   // Return from a non-void function.
   ReturnNode(intptr_t token_pos,
              AstNode* value)
       : AstNode(token_pos), value_(value), inlined_finally_list_() {
-    ASSERT(value != NULL);
+    ASSERT(value_ != NULL);
   }
 
   AstNode* value() const { return value_; }
 
   intptr_t inlined_finally_list_length() const {
     return inlined_finally_list_.length();
   }
   InlinedFinallyNode* InlinedFinallyNodeAt(intptr_t index) const {
     return inlined_finally_list_[index];
   }
@@ skipping 438 matching lines @@
  private:
   Token::Kind kind_;
   SourceLabel* label_;
   GrowableArray<InlinedFinallyNode*> inlined_finally_list_;
   DISALLOW_IMPLICIT_CONSTRUCTORS(JumpNode);
 };
 
 
 class LoadLocalNode : public AstNode {
  public:
-  LoadLocalNode(intptr_t token_pos, const LocalVariable& local)
+  LoadLocalNode(intptr_t token_pos, const LocalVariable* local)
       : AstNode(token_pos), local_(local), pseudo_(NULL) {
-    ASSERT(&local_ != NULL);
+    ASSERT(local_ != NULL);

[Ivan Posva, 2012/08/03 20:10:26]

local_ = *local;

[regis, 2012/08/06 22:31:49]

This is actually not possible, because of
DISALLOW_COPY_AND_ASSIGN(LocalVariable).

I can either remove this restriction, or assign via the initializer, but this
would not prevent dereferencing of NULL:


  LoadLocalNode(intptr_t token_pos, const LocalVariable* local)
      : AstNode(token_pos), local_(*local), pseudo_(NULL) {
    ASSERT(local != NULL);
  }

   }
   // The pseudo node does not produce input but must be visited before
   // completing local load.
   LoadLocalNode(intptr_t token_pos,
-                const LocalVariable& local,
+                const LocalVariable* local,
                 AstNode* pseudo)
       : AstNode(token_pos), local_(local), pseudo_(pseudo) {
-    ASSERT(&local_ != NULL);
+    ASSERT(local_ != NULL);
   }
 
-  const LocalVariable& local() const { return local_; }
+  const LocalVariable* local() const { return local_; }

[Ivan Posva, 2012/08/03 20:10:26]

Then this change is not needed, which is causing you a massive amount of changes
to follow.

[regis, 2012/08/06 22:31:49]

Done.

   AstNode* pseudo() const { return pseudo_; }  // Can be NULL.
   bool HasPseudo() const { return pseudo_ != NULL; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     if (HasPseudo()) {
       pseudo()->Visit(visitor);
     }
   }
 
   virtual AstNode* MakeAssignmentNode(AstNode* rhs);
 
   DECLARE_COMMON_NODE_FUNCTIONS(LoadLocalNode);
 
  private:
-  const LocalVariable& local_;
+  const LocalVariable* local_;

[Ivan Posva, 2012/08/03 20:10:26]

ditto.

[regis, 2012/08/06 22:31:49]

Done.

   AstNode* pseudo_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(LoadLocalNode);
 };
 
 
 class StoreLocalNode : public AstNode {
  public:
   StoreLocalNode(intptr_t token_pos,
-                 const LocalVariable& local,
+                 const LocalVariable* local,
                  AstNode* value)
       : AstNode(token_pos), local_(local), value_(value) {
-    ASSERT(&local_ != NULL);
+    ASSERT(local_ != NULL);
     ASSERT(value_ != NULL);
   }
 
-  const LocalVariable& local() const { return local_; }
+  const LocalVariable* local() const { return local_; }
   AstNode* value() const { return value_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     value()->Visit(visitor);
   }
 
   DECLARE_COMMON_NODE_FUNCTIONS(StoreLocalNode);
 
  private:
-  const LocalVariable& local_;
+  const LocalVariable* local_;
   AstNode* value_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(StoreLocalNode);
 };
 
 
 
 class LoadInstanceFieldNode : public AstNode {
  public:
   LoadInstanceFieldNode(intptr_t token_pos,
@@ skipping 105 matching lines @@
   AstNode* value_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(StoreStaticFieldNode);
 };
 
 
 class LoadIndexedNode : public AstNode {
  public:
   LoadIndexedNode(intptr_t token_pos, AstNode* array, AstNode* index)
       : AstNode(token_pos), array_(array), index_expr_(index) {
-    ASSERT(array != NULL);
-    ASSERT(index != NULL);
+    ASSERT(array_ != NULL);
+    ASSERT(index_expr_ != NULL);
   }
 
   AstNode* array() const { return array_; }
   AstNode* index_expr() const { return index_expr_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     array()->Visit(visitor);
     index_expr()->Visit(visitor);
   }
 
   virtual AstNode* MakeAssignmentNode(AstNode* rhs);
 
   DECLARE_COMMON_NODE_FUNCTIONS(LoadIndexedNode);
 
  private:
   AstNode* array_;
   AstNode* index_expr_;
   DISALLOW_IMPLICIT_CONSTRUCTORS(LoadIndexedNode);
 };
 
 
 class StoreIndexedNode : public AstNode {
  public:
   StoreIndexedNode(intptr_t token_pos,
                    AstNode* array, AstNode* index, AstNode* value)
     : AstNode(token_pos), array_(array), index_expr_(index), value_(value) {
-    ASSERT(array != NULL);
-    ASSERT(index != NULL);
-    ASSERT(value != NULL);
+    ASSERT(array_ != NULL);
+    ASSERT(index_expr_ != NULL);
+    ASSERT(value_ != NULL);
   }
 
   AstNode* array() const { return array_; }
   AstNode* index_expr() const { return index_expr_; }
   AstNode* value() const { return value_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     array()->Visit(visitor);
     index_expr()->Visit(visitor);
     value()->Visit(visitor);
@@ skipping 157 matching lines @@
   StaticSetterNode(intptr_t token_pos,
                    const Class& cls,
                    const String& field_name,
                    AstNode* value)
       : AstNode(token_pos),
         cls_(cls),
         field_name_(field_name),
         value_(value) {
     ASSERT(cls_.IsZoneHandle());
     ASSERT(field_name_.IsZoneHandle());
-    ASSERT(value != NULL);
+    ASSERT(value_ != NULL);
   }
 
   const Class& cls() const { return cls_; }
   const String& field_name() const { return field_name_; }
   AstNode* value() const { return value_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     value()->Visit(visitor);
   }
 
@@ skipping 95 matching lines @@
 // instantiator_class.
 //
 // A temporary local is needed to hold the allocated value while the
 // constructor is being called.
 class ConstructorCallNode : public AstNode {
  public:
   ConstructorCallNode(intptr_t token_pos,
                       const AbstractTypeArguments& type_arguments,
                       const Function& constructor,
                       ArgumentListNode* arguments,
-                      const LocalVariable& allocated_object_var)
+                      const LocalVariable* allocated_object_var)
       : AstNode(token_pos),
         type_arguments_(type_arguments),
         constructor_(constructor),
         arguments_(arguments),
         allocated_object_var_(allocated_object_var) {
     ASSERT(type_arguments_.IsZoneHandle());
     ASSERT(constructor_.IsZoneHandle());
     ASSERT(arguments_ != NULL);
+    ASSERT(allocated_object_var_ != NULL);
   }
 
   const AbstractTypeArguments& type_arguments() const {
     return type_arguments_;
   }
   const Function& constructor() const { return constructor_; }
   ArgumentListNode* arguments() const { return arguments_; }
-  const LocalVariable& allocated_object_var() const {
+  const LocalVariable* allocated_object_var() const {
     return allocated_object_var_;
   }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     arguments()->Visit(visitor);
   }
 
   DECLARE_COMMON_NODE_FUNCTIONS(ConstructorCallNode);
 
  private:
   const AbstractTypeArguments& type_arguments_;
   const Function& constructor_;
   ArgumentListNode* arguments_;
-  const LocalVariable& allocated_object_var_;
+  const LocalVariable* allocated_object_var_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(ConstructorCallNode);
 };
 
 
 // The body of a Dart function marked as 'native' consists of this node.
 class NativeBodyNode : public AstNode {
  public:
   NativeBodyNode(intptr_t token_pos,
                  const String& native_c_function_name,
@@ skipping 38 matching lines @@
   DISALLOW_IMPLICIT_CONSTRUCTORS(NativeBodyNode);
 };
 
 
 class CatchClauseNode : public AstNode {
  public:
   static const int kInvalidTryIndex = -1;
 
   CatchClauseNode(intptr_t token_pos,
                   SequenceNode* catch_block,
-                  const LocalVariable& context_var,
-                  const LocalVariable& exception_var,
-                  const LocalVariable& stacktrace_var)
+                  const LocalVariable* context_var,
+                  const LocalVariable* exception_var,
+                  const LocalVariable* stacktrace_var)
       : AstNode(token_pos),
         try_index_(kInvalidTryIndex),
         catch_block_(catch_block),
         context_var_(context_var),
         exception_var_(exception_var),
         stacktrace_var_(stacktrace_var) {
-    ASSERT(catch_block != NULL);
+    ASSERT(catch_block_ != NULL);
+    ASSERT(context_var_ != NULL);
+    ASSERT(exception_var_ != NULL);
+    ASSERT(stacktrace_var_ != NULL);
   }
 
   int try_index() const {
     ASSERT(try_index_ >= 0);
     return try_index_;
   }
   void set_try_index(int value) { try_index_ = value; }
 
-  const LocalVariable& context_var() const { return context_var_; }
-  const LocalVariable& exception_var() const { return exception_var_; }
-  const LocalVariable& stacktrace_var() const { return stacktrace_var_; }
+  const LocalVariable* context_var() const { return context_var_; }
+  const LocalVariable* exception_var() const { return exception_var_; }
+  const LocalVariable* stacktrace_var() const { return stacktrace_var_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     catch_block_->Visit(visitor);
   }
 
   DECLARE_COMMON_NODE_FUNCTIONS(CatchClauseNode);
 
  private:
   int try_index_;  // Running index of the try blocks seen in a function.
   SequenceNode* catch_block_;
-  const LocalVariable& context_var_;
-  const LocalVariable& exception_var_;
-  const LocalVariable& stacktrace_var_;
+  const LocalVariable* context_var_;
+  const LocalVariable* exception_var_;
+  const LocalVariable* stacktrace_var_;
 
   DISALLOW_COPY_AND_ASSIGN(CatchClauseNode);
 };
 
 
 class TryCatchNode : public AstNode {
  public:
   TryCatchNode(intptr_t token_pos,
                SequenceNode* try_block,
                SourceLabel* end_catch_label,
-               const LocalVariable& context_var,
+               const LocalVariable* context_var,
                CatchClauseNode* catch_block,
                SequenceNode* finally_block)
       : AstNode(token_pos),
         try_block_(try_block),
         end_catch_label_(end_catch_label),
         context_var_(context_var),
         catch_block_(catch_block),
         finally_block_(finally_block) {
-    ASSERT(try_block != NULL);
-    ASSERT(catch_block != NULL || finally_block != NULL);
-    ASSERT(end_catch_label != NULL);
+    ASSERT(try_block_ != NULL);
+    ASSERT(context_var_ != NULL);
+    ASSERT(catch_block_ != NULL || finally_block_ != NULL);
+    ASSERT(end_catch_label_ != NULL);
   }
 
   SequenceNode* try_block() const { return try_block_; }
   SourceLabel* end_catch_label() const { return end_catch_label_; }
   CatchClauseNode* catch_block() const { return catch_block_; }
   SequenceNode* finally_block() const { return finally_block_; }
-  const LocalVariable& context_var() const { return context_var_; }
+  const LocalVariable* context_var() const { return context_var_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     try_block_->Visit(visitor);
     if (catch_block_ != NULL) {
       catch_block_->Visit(visitor);
     }
     if (finally_block_ != NULL) {
       finally_block_->Visit(visitor);
     }
   }
 
   DECLARE_COMMON_NODE_FUNCTIONS(TryCatchNode);
 
  private:
   SequenceNode* try_block_;
   SourceLabel* end_catch_label_;
-  const LocalVariable& context_var_;
+  const LocalVariable* context_var_;
   CatchClauseNode* catch_block_;
   SequenceNode* finally_block_;
 
   DISALLOW_COPY_AND_ASSIGN(TryCatchNode);
 };
 
 
 class ThrowNode : public AstNode {
  public:
   ThrowNode(intptr_t token_pos, AstNode* exception, AstNode* stacktrace)
       : AstNode(token_pos), exception_(exception), stacktrace_(stacktrace) {
-    ASSERT(exception != NULL);
+    ASSERT(exception_ != NULL);
   }
 
   AstNode* exception() const { return exception_; }
   AstNode* stacktrace() const { return stacktrace_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     exception()->Visit(visitor);
     if (stacktrace() != NULL) {
       stacktrace()->Visit(visitor);
     }
   }
 
   DECLARE_COMMON_NODE_FUNCTIONS(ThrowNode);
  private:
   AstNode* exception_;
   AstNode* stacktrace_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(ThrowNode);
 };
 
 
 class InlinedFinallyNode : public AstNode {
  public:
   InlinedFinallyNode(intptr_t token_pos,
                      AstNode* finally_block,
-                     const LocalVariable& context_var)
+                     const LocalVariable* context_var)
       : AstNode(token_pos),
         finally_block_(finally_block),
         context_var_(context_var) {
-    ASSERT(finally_block != NULL);
+    ASSERT(finally_block_ != NULL);
+    ASSERT(context_var_ != NULL);
   }
 
   AstNode* finally_block() const { return finally_block_; }
-  const LocalVariable& context_var() const { return context_var_; }
+  const LocalVariable* context_var() const { return context_var_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     finally_block()->Visit(visitor);
   }
 
   DECLARE_COMMON_NODE_FUNCTIONS(InlinedFinallyNode);
+

[Ivan Posva, 2012/08/03 20:10:26]

Why here, but not on line 1634?

[regis, 2012/08/06 22:31:49]

Added new line after 1634.

  private:
   AstNode* finally_block_;
-  const LocalVariable& context_var_;
+  const LocalVariable* context_var_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(InlinedFinallyNode);
 };
 
 }  // namespace dart
 
 #undef DECLARE_COMMON_NODE_FUNCTIONS
 
 #endif  // VM_AST_H_