Store pointer instead of reference to LocalVariable in ast and flow graph.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 1339 matching lines @@
       NameVisibility name_visibility) const {
     const bool instantiate = true;
     return BuildSignature(instantiate, name_visibility, instantiator);
   }
 
   // Returns true if the signature of this function is instantiated, i.e. if it
   // does not involve generic parameter types or generic result type.
   bool HasInstantiatedSignature() const;
 
   RawClass* owner() const { return raw_ptr()->owner_; }
-  void set_owner(const Class& value) const;
 
   RawAbstractType* result_type() const { return raw_ptr()->result_type_; }

[Ivan Posva, 2012/08/03 20:10:26]

This is a completely unrelated change. Please remove.

[regis, 2012/08/06 22:31:49]

As the title of this cl states, this is a follow up to revision 10203 to address
late comments by Matthias.

   void set_result_type(const AbstractType& value) const;
 
   RawAbstractType* ParameterTypeAt(intptr_t index) const;
   void SetParameterTypeAt(intptr_t index, const AbstractType& value) const;
   void set_parameter_types(const Array& value) const;
 
   // Parameter names are valid for all valid parameter indices, and are not
   // limited to named optional parameters.
   RawString* ParameterNameAt(intptr_t index) const;
   void SetParameterNameAt(intptr_t index, const String& value) const;
@@ skipping 250 matching lines @@
   static const int kCtorPhaseBody = 1 << 1;
   static const int kCtorPhaseAll = (kCtorPhaseInit | kCtorPhaseBody);
 
  private:
   void set_name(const String& value) const;
   void set_kind(RawFunction::Kind value) const;
   void set_is_static(bool is_static) const;
   void set_is_const(bool is_const) const;
   void set_is_external(bool value) const;
   void set_parent_function(const Function& value) const;
+  void set_owner(const Class& value) const;
   void set_token_pos(intptr_t value) const;
   void set_implicit_closure_function(const Function& value) const;
   static RawFunction* New();
 
   RawString* BuildSignature(bool instantiate,
                             NameVisibility name_visibility,
                             const AbstractTypeArguments& instantiator) const;
 
   // Check the subtype or 'more specific' relationship.
   bool TypeTest(TypeTestKind test_kind,
@@ skipping 24 matching lines @@
   bool is_final() const { return raw_ptr()->is_final_; }
   bool is_const() const { return raw_ptr()->is_const_; }
 
   inline intptr_t Offset() const;
   inline void SetOffset(intptr_t value) const;
 
   RawInstance* value() const;
   void set_value(const Instance& value) const;
 
   RawClass* owner() const { return raw_ptr()->owner_; }
-  void set_owner(const Class& value) const {
-    StorePointer(&raw_ptr()->owner_, value.raw());
-  }
 
   RawAbstractType* type() const  { return raw_ptr()->type_; }
   void set_type(const AbstractType& value) const;
 
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawField));
   }
 
   static RawField* New(const String& name,
                        bool is_static,
@@ skipping 25 matching lines @@
   void set_name(const String& value) const;
   void set_is_static(bool is_static) const {
     raw_ptr()->is_static_ = is_static;
   }
   void set_is_final(bool is_final) const {
     raw_ptr()->is_final_ = is_final;
   }
   void set_is_const(bool value) const {
     raw_ptr()->is_const_ = value;
   }
+  void set_owner(const Class& value) const {
+    StorePointer(&raw_ptr()->owner_, value.raw());
+  }
   void set_token_pos(intptr_t token_pos) const {
     raw_ptr()->token_pos_ = token_pos;
   }
   static RawField* New();
 
   HEAP_OBJECT_IMPLEMENTATION(Field, Object);
   friend class Class;
 };
 
 
@@ skipping 3710 matching lines @@
     if (this->CharAt(i) != str.CharAt(begin_index + i)) {
       return false;
     }
   }
   return true;
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_