Store pointer instead of reference to LocalVariable in ast and flow graph.

runtime/vm/code_generator_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
 
 #include "vm/ast.h"
 #include "vm/assembler.h"
@@ skipping 45 matching lines @@
 CODEGEN_TEST_GENERATE(ReturnParameterCodegen, test) {
   SequenceNode* node_seq = test->node_sequence();
   const int num_params = 1;
   LocalVariable* parameter = NewTestLocalVariable("parameter");
   LocalScope* local_scope = node_seq->scope();
   local_scope->AddVariable(parameter);
   ASSERT(local_scope->num_variables() == num_params);
   const Function& function = test->function();
   function.set_num_fixed_parameters(num_params);
   ASSERT(function.num_optional_parameters() == 0);
-  node_seq->Add(new ReturnNode(kPos, new LoadLocalNode(kPos, *parameter)));
+  node_seq->Add(new ReturnNode(kPos, new LoadLocalNode(kPos, parameter)));
 }
 
 
 CODEGEN_TEST2_GENERATE(StaticCallReturnParameterCodegen, function, test) {
   // Wrap and call the ReturnParameterCodegen test above as a static function.
   SequenceNode* node_seq = test->node_sequence();
   ArgumentListNode* arguments = new ArgumentListNode(kPos);
   arguments->Add(new LiteralNode(kPos, Smi::ZoneHandle(Smi::New(3))));
   node_seq->Add(new ReturnNode(kPos,
                                new StaticCallNode(kPos, function, arguments)));
@@ skipping 13 matching lines @@
   LocalScope* local_scope = node_seq->scope();
   local_scope->AddVariable(param1);
   local_scope->AddVariable(param2);
   local_scope->AddVariable(sum);
   ASSERT(local_scope->num_variables() == num_params + num_locals);
   const Function& function = test->function();
   function.set_num_fixed_parameters(num_params);
   ASSERT(function.num_optional_parameters() == 0);
   BinaryOpNode* add = new BinaryOpNode(kPos,
                                        Token::kADD,
-                                       new LoadLocalNode(kPos, *param1),
-                                       new LoadLocalNode(kPos, *param2));
-  node_seq->Add(new StoreLocalNode(kPos, *sum, add));
-  node_seq->Add(new ReturnNode(kPos, new LoadLocalNode(kPos, *sum)));
+                                       new LoadLocalNode(kPos, param1),
+                                       new LoadLocalNode(kPos, param2));
+  node_seq->Add(new StoreLocalNode(kPos, sum, add));
+  node_seq->Add(new ReturnNode(kPos, new LoadLocalNode(kPos, sum)));
 }
 
 
 CODEGEN_TEST2_GENERATE(StaticCallSmiParamSumCodegen, function, test) {
   // Wrap and call the SmiParamSumCodegen test above as a static function.
   SequenceNode* node_seq = test->node_sequence();
   ArgumentListNode* arguments = new ArgumentListNode(kPos);
   arguments->Add(new LiteralNode(kPos, Smi::ZoneHandle(Smi::New(3))));
   arguments->Add(new LiteralNode(kPos, Smi::ZoneHandle(Smi::New(2))));
   node_seq->Add(new ReturnNode(kPos,
@@ skipping 231 matching lines @@
 
   String& constructor_name = String::Handle(String::New("A."));
   Function& constructor =
       Function::ZoneHandle(cls.LookupConstructor(constructor_name));
   EXPECT(!constructor.IsNull());
 
   // The unit test creates an instance of class A and calls function 'bar'.
   String& function_bar_name = String::ZoneHandle(Symbols::New("bar"));
   ArgumentListNode* no_arguments = new ArgumentListNode(kPos);
   const TypeArguments& no_type_arguments = TypeArguments::ZoneHandle();
-  const LocalVariable& allocated = *test->CreateTempConstVariable("alloc");
+  const LocalVariable* allocated = test->CreateTempConstVariable("alloc");
   InstanceCallNode* call_bar = new InstanceCallNode(
       kPos,
       new ConstructorCallNode(
           kPos, no_type_arguments, constructor, no_arguments, allocated),
       function_bar_name,
       no_arguments);
 
   test->node_sequence()->Add(new ReturnNode(kPos, call_bar));
 }
 CODEGEN_TEST_RUN(InstanceCallCodegen, Smi::New(42))
@@ skipping 117 matching lines @@
   Class& cls = Class::ZoneHandle(LookupClass(lib, "A"));
   EXPECT(!cls.IsNull());
 
   String& constructor_name = String::Handle(String::New("A."));
   Function& constructor =
       Function::ZoneHandle(cls.LookupConstructor(constructor_name));
   EXPECT(!constructor.IsNull());
 
   const TypeArguments& no_type_arguments = TypeArguments::ZoneHandle();
   ArgumentListNode* no_arguments = new ArgumentListNode(kPos);
-  const LocalVariable& allocated = *test->CreateTempConstVariable("alloc");
+  const LocalVariable* allocated = test->CreateTempConstVariable("alloc");
   test->node_sequence()->Add(new ReturnNode(kPos, new ConstructorCallNode(
       kPos, no_type_arguments, constructor, no_arguments, allocated)));
 }
 
 
 CODEGEN_TEST_RAW_RUN(AllocateNewObjectCodegen, function) {
   GrowableArray<const Object*> arguments;
   const Array& kNoArgumentNames = Array::Handle();
   Object& result = Object::Handle();
   result = DartEntry::InvokeStatic(function, arguments, kNoArgumentNames);
   EXPECT(!result.IsError());
   const GrowableObjectArray& libs =  GrowableObjectArray::Handle(
       Isolate::Current()->object_store()->libraries());
   ASSERT(!libs.IsNull());
   // App lib is the last one that was loaded.
   intptr_t num_libs = libs.Length();
   Library& app_lib = Library::Handle();
   app_lib ^= libs.At(num_libs - 1);
   ASSERT(!app_lib.IsNull());
   const Class& cls = Class::Handle(
       app_lib.LookupClass(String::Handle(Symbols::New("A"))));
   EXPECT_EQ(cls.raw(), result.clazz());
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32 || defined(TARGET_ARCH_X64)