Refactor our IL instruction for static setters.

Refactor our IL instruction for static setters.

We do not need a separate IL instruction anymore. Instead I generate
a normal static call and save the result in a temporary local if it
is needed.
Committed: https://code.google.com/p/dart/source/detail?r=10222

[Vyacheslav Egorov (Google), 2012-08-03 10:50:00]

lgtm

[hausner, 2012-08-03 22:32:52]

DBC

https://chromiumcodereview.appspot.com/10825176/diff/1/vm/parser.cc
File vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10825176/diff/1/vm/parser.cc#newcode6475
vm/parser.cc:6475: result->IsStaticSetterNode())) {
FWIW, I don't think that for static setters you need to ensure that a temporary
variable is available. We don't do any gymnastics with static setters in
PrepareCompoundAssignmentNodes().

[Florian Schneider, 2012-08-06 09:06:25]

https://chromiumcodereview.appspot.com/10825176/diff/1/vm/parser.cc
File vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10825176/diff/1/vm/parser.cc#newcode6475
vm/parser.cc:6475: result->IsStaticSetterNode())) {
On 2012/08/03 22:32:52, hausner wrote:
> FWIW, I don't think that for static setters you need to ensure that a
temporary
> variable is available. We don't do any gymnastics with static setters in
> PrepareCompoundAssignmentNodes().

We still need to preserve the value if the setter expression occurs in a value
context: var x = A.foo = 123.