Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: vm/intermediate_language_ia32.cc

Issue 10825176: Refactor our IL instruction for static setters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/intermediate_language_ia32.cc
===================================================================
--- vm/intermediate_language_ia32.cc (revision 10216)
+++ vm/intermediate_language_ia32.cc (working copy)
@@ -1006,35 +1006,6 @@
}
-LocationSummary* StaticSetterComp::MakeLocationSummary() const {
- const intptr_t kNumInputs = 1;
- return LocationSummary::Make(kNumInputs,
- Location::RequiresRegister(),
- LocationSummary::kNoCall);
-}
-
-
-void StaticSetterComp::EmitNativeCode(FlowGraphCompiler* compiler) {
- Register value = locs()->in(0).reg();
- Register result = locs()->out().reg();
-
- // Preserve the argument as the result of the computation,
- // then call the setter.
-
- // Duplicate the argument.
- // TODO(fschneider): Avoid preserving the value if the result is not used.
- __ pushl(value);
- __ pushl(value);
- compiler->GenerateStaticCall(cid(),
- token_pos(),
- try_index(),
- setter_function(),
- 1,
- Array::ZoneHandle());
- __ popl(result);
-}
-
-
LocationSummary* LoadInstanceFieldComp::MakeLocationSummary() const {
// TODO(fschneider): For this instruction the input register may be
// reused for the result (but is not required to) because the input
« no previous file with comments | « vm/intermediate_language.cc ('k') | vm/intermediate_language_x64.cc » ('j') | vm/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698