Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: vm/intermediate_language.h

Issue 10825176: Refactor our IL instruction for static setters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/intermediate_language.h
===================================================================
--- vm/intermediate_language.h (revision 10216)
+++ vm/intermediate_language.h (working copy)
@@ -76,7 +76,6 @@
M(LoadIndexed, LoadIndexedComp) \
M(StoreIndexed, StoreIndexedComp) \
M(InstanceSetter, InstanceSetterComp) \
- M(StaticSetter, StaticSetterComp) \
M(LoadInstanceField, LoadInstanceFieldComp) \
M(StoreInstanceField, StoreInstanceFieldComp) \
M(LoadStaticField, LoadStaticFieldComp) \
@@ -1079,38 +1078,6 @@
};
-// Not simply a StaticCall because it has somewhat more complicated
-// semantics: the value operand is preserved before the call.
-class StaticSetterComp : public TemplateComputation<1> {
- public:
- StaticSetterComp(intptr_t token_pos,
- intptr_t try_index,
- const Function& setter_function,
- Value* value)
- : token_pos_(token_pos),
- try_index_(try_index),
- setter_function_(setter_function) {
- inputs_[0] = value;
- }
-
- DECLARE_COMPUTATION(StaticSetter)
-
- intptr_t token_pos() const { return token_pos_; }
- intptr_t try_index() const { return try_index_; }
- const Function& setter_function() const { return setter_function_; }
- Value* value() const { return inputs_[0]; }
-
- virtual bool CanDeoptimize() const { return false; }
-
- private:
- const intptr_t token_pos_;
- const intptr_t try_index_;
- const Function& setter_function_;
-
- DISALLOW_COPY_AND_ASSIGN(StaticSetterComp);
-};
-
-
// Note overrideable, built-in: value? false : true.
class BooleanNegateComp : public TemplateComputation<1> {
public:
« no previous file with comments | « vm/flow_graph_builder.cc ('k') | vm/intermediate_language.cc » ('j') | vm/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698