Refactor our IL instruction for static setters.

vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 6452 matching lines @@
     return left_node;
   }
   return *expr;
 }
 
 
 // Ensure that the expression temp is allocated for nodes that may need it.
 AstNode* Parser::CreateAssignmentNode(AstNode* original, AstNode* rhs) {
   AstNode* result = original->MakeAssignmentNode(rhs);
   if ((result != NULL) &&
-      (result->IsStoreIndexedNode() || result->IsInstanceSetterNode())) {
+      (result->IsStoreIndexedNode() ||
+       result->IsInstanceSetterNode() ||
+       result->IsStaticSetterNode())) {

[hausner, 2012/08/03 22:32:52]

FWIW, I don't think that for static setters you need to ensure that a temporary
variable is available. We don't do any gymnastics with static setters in
PrepareCompoundAssignmentNodes().

[Florian Schneider, 2012/08/06 09:06:25]

We still need to preserve the value if the setter expression occurs in a value
context: var x = A.foo = 123.

     EnsureExpressionTemp();
   }
   return result;
 }
 
 
 AstNode* Parser::ParseCascades(AstNode* expr) {
   intptr_t cascade_pos = TokenPos();
   LocalVariable* cascade_receiver_var =
       CreateTempConstVariable(cascade_pos, expr->id(), "casc");
@@ skipping 2476 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart