Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10702054: Issue 3931. Visit children nodes safely. (Closed)

Created:
8 years, 5 months ago by scheglov
Modified:
8 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -189 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartArrayAccess.java View 2 chunks +3 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartBinaryExpression.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartCase.java View 1 chunk +1 line, -1 line 1 comment Download
M compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java View 1 chunk +3 lines, -5 lines 1 comment Download
M compiler/java/com/google/dart/compiler/ast/DartClass.java View 1 chunk +2 lines, -6 lines 1 comment Download
M compiler/java/com/google/dart/compiler/ast/DartConditional.java View 2 chunks +4 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartDeclaration.java View 1 chunk +1 line, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartDoWhileStatement.java View 2 chunks +3 lines, -5 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartExprStmt.java View 1 chunk +1 line, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartField.java View 2 chunks +3 lines, -7 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartForInStatement.java View 2 chunks +4 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartForStatement.java View 2 chunks +5 lines, -11 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFunction.java View 2 chunks +3 lines, -7 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFunctionExpression.java View 2 chunks +3 lines, -5 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartFunctionTypeAlias.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartGotoStatement.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartIfStatement.java View 2 chunks +4 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartImportDirective.java View 2 chunks +4 lines, -8 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartInitializer.java View 2 chunks +3 lines, -7 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartLabel.java View 2 chunks +3 lines, -5 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartLibraryDirective.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartMapLiteralEntry.java View 2 chunks +3 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartMethodDefinition.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartMethodInvocation.java View 2 chunks +3 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNamedExpression.java View 1 chunk +2 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNativeDirective.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNewExpression.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartNode.java View 1 chunk +12 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartParameter.java View 2 chunks +3 lines, -7 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartParameterizedTypeNode.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartParenthesizedExpression.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartPropertyAccess.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartRedirectConstructorInvocation.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartResourceDirective.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartReturnStatement.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSourceDirective.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSuperConstructorInvocation.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSwitchMember.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartSwitchStatement.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartThrowStatement.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTryStatement.java View 2 chunks +3 lines, -5 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTypeExpression.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTypeNode.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartTypeParameter.java View 1 chunk +1 line, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartUnaryExpression.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartUnqualifiedInvocation.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartVariable.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartVariableStatement.java View 2 chunks +2 lines, -4 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartWhileStatement.java View 2 chunks +3 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 5 months ago (2012-06-30 00:38:00 UTC) #1
Brian Wilkerson
8 years, 5 months ago (2012-06-30 00:44:21 UTC) #2 
LGTM

https://chromiumcodereview.appspot.com/10702054/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/ast/DartCase.java (right):

https://chromiumcodereview.appspot.com/10702054/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/ast/DartCase.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10702054/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java (right):

https://chromiumcodereview.appspot.com/10702054/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10702054/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/ast/DartClass.java (right):

https://chromiumcodereview.appspot.com/10702054/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/ast/DartClass.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

Powered by Google App Engine
This is Rietveld 408576698