Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartForStatement.java

Issue 10702054: Issue 3931. Visit children nodes safely. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartForStatement.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartForStatement.java b/compiler/java/com/google/dart/compiler/ast/DartForStatement.java
index 828e1653975f132678ff58923284566c75b95a11..d5ba0e267e7b44c508cbc19a622b97cb4cd89384 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartForStatement.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartForStatement.java
@@ -1,4 +1,4 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -40,16 +40,10 @@ public class DartForStatement extends DartStatement {
@Override
public void visitChildren(ASTVisitor<?> visitor) {
- if (init != null) {
- init.accept(visitor);
- }
- if (condition != null) {
- condition.accept(visitor);
- }
- if (increment != null) {
- increment.accept(visitor);
- }
- body.accept(visitor);
+ safelyVisitChild(init, visitor);
+ safelyVisitChild(condition, visitor);
+ safelyVisitChild(increment, visitor);
+ safelyVisitChild(body, visitor);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698