Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java

Issue 10702054: Issue 3931. Visit children nodes safely. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java b/compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java
index f1833e4d89b022f695e9123f4d295d6e0ac4122b..fb14eef80cdac046de927936afe9948341a2986d 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartCatchBlock.java
@@ -34,11 +34,9 @@ public class DartCatchBlock extends DartStatement {
@Override
public void visitChildren(ASTVisitor<?> visitor) {
- exception.accept(visitor);
- if (stackTrace != null) {
- stackTrace.accept(visitor);
- }
- block.accept(visitor);
+ safelyVisitChild(exception, visitor);
+ safelyVisitChild(stackTrace, visitor);
+ safelyVisitChild(block, visitor);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698