Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartTryStatement.java

Issue 10702054: Issue 3931. Visit children nodes safely. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartTryStatement.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartTryStatement.java b/compiler/java/com/google/dart/compiler/ast/DartTryStatement.java
index 4357f92fffdfe46a6dcebe8aefb016a7096b68c2..14f542f7489531b7cc64f95e81ebee7566ada14a 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartTryStatement.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartTryStatement.java
@@ -1,4 +1,4 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -36,11 +36,9 @@ public class DartTryStatement extends DartStatement {
@Override
public void visitChildren(ASTVisitor<?> visitor) {
- tryBlock.accept(visitor);
+ safelyVisitChild(tryBlock, visitor);
catchBlocks.accept(visitor);
- if (finallyBlock != null) {
- finallyBlock.accept(visitor);
- }
+ safelyVisitChild(finallyBlock, visitor);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698