Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10548047: Remove frog from the repository. (Closed)

Created:
8 years, 6 months ago by kasperl
Modified:
8 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove frog from the repository. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8709

Patch Set 1 #

Patch Set 2 : Fix SDK dartdoc/frog. #

Total comments: 4

Patch Set 3 : Move test and update apidoc.gyp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25188 lines) Patch
M dart.gyp View 2 chunks +0 lines, -7 lines 0 comments Download
D frog/.gitignore View 1 chunk +0 lines, -17 lines 0 comments Download
D frog/README.txt View 1 chunk +0 lines, -52 lines 0 comments Download
D frog/analyze.dart View 1 chunk +0 lines, -793 lines 0 comments Download
D frog/analyze_frame.dart View 1 chunk +0 lines, -175 lines 0 comments Download
D frog/await/awaitc.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D frog/await/checker.dart View 1 chunk +0 lines, -369 lines 0 comments Download
D frog/await/nodeset.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D frog/await/normalizer.dart View 1 chunk +0 lines, -451 lines 0 comments Download
D frog/await/samples/dartcombat/README View 1 chunk +0 lines, -6 lines 0 comments Download
D frog/await/samples/dartcombat/dartcombat.css View 1 chunk +0 lines, -171 lines 0 comments Download
D frog/await/samples/dartcombat/dartcombat.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D frog/await/samples/dartcombat/dartcombat.html View 1 chunk +0 lines, -14 lines 0 comments Download
D frog/await/samples/dartcombat/dartcombatlib.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D frog/await/samples/dartcombat/grids.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D frog/await/samples/dartcombat/icons.gif View 0 chunks +-1 lines, --1 lines 0 comments Download
D frog/await/samples/dartcombat/player.dart View 1 chunk +0 lines, -112 lines 0 comments Download
D frog/await/samples/dartcombat/setup.dart View 1 chunk +0 lines, -95 lines 0 comments Download
D frog/await/samples/dartcombat/state.dart View 1 chunk +0 lines, -280 lines 0 comments Download
D frog/await/samples/dartcombat/views.dart View 1 chunk +0 lines, -297 lines 0 comments Download
D frog/await/samples/mintmaker/mintmaker.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D frog/await/transformation.dart View 1 chunk +0 lines, -628 lines 0 comments Download
D frog/block_scope.dart View 1 chunk +0 lines, -222 lines 0 comments Download
D frog/code_writer.dart View 1 chunk +0 lines, -110 lines 0 comments Download
D frog/codereview.settings View 1 chunk +0 lines, -4 lines 0 comments Download
D frog/corejs.dart View 1 chunk +0 lines, -642 lines 0 comments Download
D frog/dart-frog.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
D frog/element.dart View 1 chunk +0 lines, -183 lines 0 comments Download
D frog/evaluator.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D frog/file_system.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D frog/file_system_dom.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D frog/file_system_memory.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D frog/file_system_vm.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D frog/frog.py View 1 chunk +0 lines, -233 lines 0 comments Download
D frog/frog_leg.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D frog/frog_options.dart View 1 chunk +0 lines, -211 lines 0 comments Download
D frog/frogc.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D frog/gen.dart View 1 chunk +0 lines, -2545 lines 0 comments Download
D frog/lang.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D frog/lib/arrays.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D frog/lib/corelib.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D frog/lib/corelib_impl.dart View 1 chunk +0 lines, -529 lines 0 comments Download
D frog/lib/date_implementation.dart View 1 chunk +0 lines, -301 lines 0 comments Download
D frog/lib/frog_coreimpl_sources.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
D frog/lib/frog_corelib_sources.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
D frog/lib/function_implementation.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D frog/lib/math.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D frog/lib/natives.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D frog/lib/num.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D frog/lib/string_base.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D frog/lib/string_buffer.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D frog/lib/string_implementation.dart View 1 chunk +0 lines, -184 lines 0 comments Download
D frog/library.dart View 1 chunk +0 lines, -509 lines 0 comments Download
D frog/member.dart View 1 chunk +0 lines, -1444 lines 0 comments Download
D frog/member_set.dart View 1 chunk +0 lines, -304 lines 0 comments Download
D frog/method_data.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D frog/minfrogc.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D frog/parser.dart View 1 chunk +0 lines, -1748 lines 0 comments Download
D frog/presubmit.py View 1 chunk +0 lines, -137 lines 0 comments Download
D frog/reader.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D frog/scripts/bootstrap/build_frogpad_js.py View 1 chunk +0 lines, -51 lines 0 comments Download
D frog/scripts/bootstrap/frog.bat View 1 chunk +0 lines, -21 lines 0 comments Download
D frog/scripts/bootstrap/frog_bootstrap_wrapper.py View 1 chunk +0 lines, -44 lines 0 comments Download
D frog/scripts/bootstrap/frog_wrapper.py View 1 chunk +0 lines, -47 lines 0 comments Download
D frog/scripts/bootstrap/frogc View 1 chunk +0 lines, -7 lines 0 comments Download
D frog/scripts/bootstrap/frogc.bat View 1 chunk +0 lines, -18 lines 0 comments Download
D frog/scripts/codegen.py View 1 chunk +0 lines, -58 lines 0 comments Download
D frog/scripts/corejs_gen.py View 1 chunk +0 lines, -22 lines 0 comments Download
D frog/scripts/from_inputs_to_outputs.py View 1 chunk +0 lines, -18 lines 0 comments Download
D frog/scripts/token_info.py View 1 chunk +0 lines, -213 lines 0 comments Download
D frog/scripts/token_kind_gen.py View 1 chunk +0 lines, -98 lines 0 comments Download
D frog/scripts/tokenizer_gen.py View 1 chunk +0 lines, -298 lines 0 comments Download
D frog/scripts/tree_gen.py View 1 chunk +0 lines, -243 lines 0 comments Download
D frog/server/frog_server.dart View 1 chunk +0 lines, -172 lines 0 comments Download
D frog/source.dart View 1 chunk +0 lines, -186 lines 0 comments Download
D frog/tests/await/and_normalization_negative_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D frog/tests/await/and_normalization_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D frog/tests/await/await.status View 1 chunk +0 lines, -16 lines 0 comments Download
D frog/tests/await/await_no_value_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D frog/tests/await/binary_expression_normalization_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D frog/tests/await/chaining_await_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D frog/tests/await/conditional2_negative_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D frog/tests/await/conditional2_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D frog/tests/await/conditional3_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D frog/tests/await/conditional_negative_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D frog/tests/await/conditional_normalization_negative_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D frog/tests/await/conditional_normalization_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D frog/tests/await/conditional_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D frog/tests/await/dot_expression_normalization_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D frog/tests/await/doubly_nested_function_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D frog/tests/await/initializer_negative_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D frog/tests/await/mint_maker_rpc_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D frog/tests/await/multiple_declarations_normalization_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D frog/tests/await/nested_function2_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D frog/tests/await/nested_function_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D frog/tests/await/nested_try_catch2_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D frog/tests/await/nested_try_catch3_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D frog/tests/await/nested_try_catch4_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D frog/tests/await/nested_try_catch5_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D frog/tests/await/nested_try_catch_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D frog/tests/await/or_normalization_negative_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D frog/tests/await/or_normalization_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D frog/tests/await/single_await2_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D frog/tests/await/single_await_normalization_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D frog/tests/await/single_await_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D frog/tests/await/switch_statement_negative_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D frog/tests/await/top_level_function_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D frog/tests/await/try_catch10_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D frog/tests/await/try_catch2_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D frog/tests/await/try_catch3_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D frog/tests/await/try_catch4_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D frog/tests/await/try_catch5_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D frog/tests/await/try_catch6_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D frog/tests/await/try_catch7_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D frog/tests/await/try_catch8_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D frog/tests/await/try_catch9_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D frog/tests/await/try_catch_negative_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D frog/tests/await/try_catch_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D frog/tests/await/typed_function2_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D frog/tests/await/typed_function3_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D frog/tests/await/typed_function_negative_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D frog/tests/await/typed_function_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D frog/tests/await/while_loop_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D frog/tests/await/while_loop_with_break_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D frog/tests/await/while_normalization_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D frog/tests/bigtest.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D frog/tests/canvastest.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D frog/tests/frog/frog.status View 1 chunk +0 lines, -16 lines 0 comments Download
D frog/tests/frog/frog_server_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D frog/tests/frog/native_class_is_check2_frog_test.dart View 1 chunk +0 lines, -92 lines 0 comments Download
D frog/tests/frog/native_named_constructors1_frog_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D frog/tests/frog/native_named_constructors1_frog_test.js View 1 chunk +0 lines, -5 lines 0 comments Download
D frog/tests/frog/native_property_overrides_field1_frog_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D frog/tests/hello.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D frog/tests/htmltest.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D frog/tests/leg/unparser_test.dart View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D frog/tests/parser_test.dart View 1 chunk +0 lines, -312 lines 0 comments Download
D frog/tests/tests.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D frog/tests/tokenizer_test.dart View 1 chunk +0 lines, -117 lines 0 comments Download
D frog/token.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D frog/token_kind.g.dart View 1 chunk +0 lines, -585 lines 0 comments Download
D frog/tokenizer.dart View 1 chunk +0 lines, -482 lines 0 comments Download
D frog/tokenizer.g.dart View 1 chunk +0 lines, -426 lines 0 comments Download
D frog/tree.dart View 1 chunk +0 lines, -131 lines 0 comments Download
D frog/tree.g.dart View 1 chunk +0 lines, -947 lines 0 comments Download
D frog/type.dart View 1 chunk +0 lines, -1220 lines 0 comments Download
D frog/utils.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D frog/value.dart View 1 chunk +0 lines, -1665 lines 0 comments Download
D frog/var_member.dart View 1 chunk +0 lines, -276 lines 0 comments Download
D frog/world.dart View 1 chunk +0 lines, -715 lines 0 comments Download
M lib/dartdoc/frog/reader.dart View 1 1 chunk +17 lines, -9 lines 0 comments Download
A + tests/compiler/dart2js/unparser_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 2 9 chunks +16 lines, -46 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M utils/compiler/compiler.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ahe
LGTM! https://chromiumcodereview.appspot.com/10548047/diff/154/utils/apidoc/apidoc.gyp File utils/apidoc/apidoc.gyp (right): https://chromiumcodereview.appspot.com/10548047/diff/154/utils/apidoc/apidoc.gyp#newcode22 utils/apidoc/apidoc.gyp:22: '<(PRODUCT_DIR)/frog/bin/frog', You need to change this to '<(PRODUCT_DIR)/dart2js' ...
8 years, 6 months ago (2012-06-14 14:33:23 UTC) #1
kasperl
8 years, 6 months ago (2012-06-15 07:10:59 UTC) #2 
https://chromiumcodereview.appspot.com/10548047/diff/154/utils/apidoc/apidoc.gyp
File utils/apidoc/apidoc.gyp (right):

https://chromiumcodereview.appspot.com/10548047/diff/154/utils/apidoc/apidoc....
utils/apidoc/apidoc.gyp:22: '<(PRODUCT_DIR)/frog/bin/frog',
On 2012/06/14 14:33:23, ahe wrote:
> You need to change this to '<(PRODUCT_DIR)/dart2js'

Done.

https://chromiumcodereview.appspot.com/10548047/diff/154/utils/compiler/compi...
File utils/compiler/compiler.gyp (right):

https://chromiumcodereview.appspot.com/10548047/diff/154/utils/compiler/compi...
utils/compiler/compiler.gyp:15: '../../third_party/v8/src/d8.gyp:d8',
On 2012/06/14 14:33:23, ahe wrote:
> dart2js does not depend on d8.

I agree. I'll leave this in for now (to make testing a tiny bit easier for me),
but if we can move this somewhere else that would be fantastic.

Powered by Google App Engine
This is Rietveld 408576698