Issue 10414002: More String + elimination in tests

Issue 10414002: More String + elimination in tests (Closed)

Created:
8 years, 7 months ago by hausner

Modified:
8 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More String + elimination in tests Worst offender was standalone test suite Committed: https://code.google.com/p/dart/source/detail?r=7762

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -57 lines)			Patch
M	tests/corelib/reg_exp4_test.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/corelib/reg_exp5_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/string_buffer_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/v2_unresolved_ports_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/standalone/crypto/base64_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/standalone/io/directory_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/file_input_stream_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/file_invalid_arguments_test.dart	View	4 chunks	+4 lines, -4 lines	2 comments	Download
M	tests/standalone/io/file_test.dart	View	14 chunks	+18 lines, -15 lines	0 comments	Download
M	tests/standalone/io/http_server_socket_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_working_directory_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/read_into_const_list_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/stream_pipe_test.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/standalone/package/packages/lib1.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/package/packages/lib2/lib2.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/package/packages/lib3/sub/lib3.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/status_expression_test.dart	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/10414002/diff/1/tests/standalone/io/file_invalid_arguments_test.dart File tests/standalone/io/file_invalid_arguments_test.dart (right): http://codereview.chromium.org/10414002/diff/1/tests/standalone/io/file_invalid_arguments_test.dart#newcode92 tests/standalone/io/file_invalid_arguments_test.dart:92: var file = (new File(filename.concat("_out"))).openSync(FileMode.WRITE); Why do you ...

8 years, 7 months ago (2012-05-18 19:56:10 UTC) #2

hausner

8 years, 7 months ago (2012-05-18 21:03:46 UTC) #3

Thanks you.

http://codereview.chromium.org/10414002/diff/1/tests/standalone/io/file_inval...
File tests/standalone/io/file_invalid_arguments_test.dart (right):

http://codereview.chromium.org/10414002/diff/1/tests/standalone/io/file_inval...
tests/standalone/io/file_invalid_arguments_test.dart:92: var file = (new
File(filename.concat("_out"))).openSync(FileMode.WRITE);
No particular reason, it just seemed more readable to me. If the code owners
don't like it, they can change it to use interpolation.

On 2012/05/18 19:56:10, asiva wrote:
> Why do you use concat here and not:
> new File("${filename}_out").openSync(FileMode.WRITE);

Expand Messages | Collapse Messages