tests/standalone/io/stream_pipe_test.dart - Issue 10414002: More String + elimination in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/stream_pipe_test.dart

Issue 10414002: More String + elimination in tests (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests/standalone/io/file_invalid_arguments_test.dart ('K') | « tests/standalone/io/read_into_const_list_test.dart ('k') | tests/standalone/package/packages/lib1.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/standalone/io/stream_pipe_test.dart

===================================================================

--- tests/standalone/io/stream_pipe_test.dart (revision 7745)

+++ tests/standalone/io/stream_pipe_test.dart (working copy)

@@ -14,7 +14,7 @@

// Helper method to be able to run the test from the runtime

// directory, or the top directory.

String getDataFilename(String path) =>

- new File(path).existsSync() ? path : '../' + path;

+ new File(path).existsSync() ? path : '../$path';

bool compareFileContent(String fileName1,

@@ -86,7 +86,7 @@

fileInput.onClosed = () {

SocketInputStream socketInput = _socket.inputStream;

var tempDir = new Directory('').createTempSync();

- var dstFileName = tempDir.path + "/readline_test1.dat";

+ var dstFileName = tempDir.path.concat("/readline_test1.dat");

var dstFile = new File(dstFileName);

dstFile.createSync();

var fileOutput = dstFile.openOutputStream();

@@ -170,7 +170,7 @@

var srcStream = new File(srcFileName).openInputStream();

var tempDir = new Directory('').createTempSync();

- String dstFileName = tempDir.path + "/readline_test1.dat";

+ String dstFileName = tempDir.path.concat("/readline_test1.dat");

new File(dstFileName).createSync();

var dstStream = new File(dstFileName).openOutputStream();

@@ -200,7 +200,7 @@

var srcStream = srcFile.openInputStream();

var tempDir = new Directory('').createTempSync();

- var dstFileName = tempDir.path + "/readline_test1.dat";

+ var dstFileName = tempDir.path.concat("/readline_test1.dat");

var dstFile = new File(dstFileName);

dstFile.createSync();

var dstStream = dstFile.openOutputStream();

@@ -246,7 +246,7 @@

var srcStream = srcFile.openInputStream();

var tempDir = new Directory('').createTempSync();

- var dstFileName = tempDir.path + "/readline_test1.dat";

+ var dstFileName = tempDir.path.concat("/readline_test1.dat");

var dstFile = new File(dstFileName);

dstFile.createSync();

var dstStream = dstFile.openOutputStream();