Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: tests/standalone/status_expression_test.dart

Issue 10414002: More String + elimination in tests (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/status_expression_test.dart
===================================================================
--- tests/standalone/status_expression_test.dart (revision 7745)
+++ tests/standalone/status_expression_test.dart (working copy)
@@ -42,7 +42,7 @@
environment["mode"] = "debug";
Expect.isFalse(ast.evaluate(environment));
environment["arch"] = "chromium";
- Expect.isTrue(ast.evaluate(environment));
+ Expect.isTrue(ast.evaluate(environment));
}
static void test2() {
@@ -54,7 +54,7 @@
["(", "\$", "arch", "==", "dartc", "||", "\$", "arch", "==",
"chromium", ")", "&&", "\$", "mode", "==", "release"]);
}
-
+
static void test3() {
var thrown;
String input = @" $mode == debug && ($arch==chromium || *$arch == dartc)";
@@ -82,14 +82,14 @@
static void test5() {
Tokenizer tokenizer = new Tokenizer(
- @"Skip , Pass if $arch == dartc, Fail || Timeout if " +
+ @"Skip , Pass if $arch == dartc, Fail || Timeout if "
@"$arch == chromium && $mode == release");
tokenizer.tokenize();
ExpressionParser parser =
new ExpressionParser(new Scanner(tokenizer.tokens));
SetExpression ast = parser.parseSetExpression();
Expect.equals(
- @"((skip || (pass if ($arch == dartc))) || ((fail || timeout) " +
+ @"((skip || (pass if ($arch == dartc))) || ((fail || timeout) "
@"if (($arch == chromium) && ($mode == release))))",
ast.toString());
@@ -140,9 +140,9 @@
environment["arch"] = "arm";
Expect.isFalse(ast.evaluate(environment));
environment["checked"] = true;
- Expect.isFalse(ast.evaluate(environment));
+ Expect.isFalse(ast.evaluate(environment));
}
-}
+}
main() {
StatusExpressionTest.testMain();

Powered by Google App Engine
This is Rietveld 408576698