Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1671)

Unified Diff: tools/testing/dart/test_options.dart

Issue 10414002: More String + elimination in tests (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_options.dart
===================================================================
--- tools/testing/dart/test_options.dart (revision 7745)
+++ tools/testing/dart/test_options.dart (working copy)
@@ -93,7 +93,7 @@
dartium: Run Dart or JavaScript in Dartium.
- [ff | chrome | safari | ie | opera]: Run JavaScript in the specified
+ [ff | chrome | safari | ie | opera]: Run JavaScript in the specified
browser.
none: No runtime, compile only (for example, used for dartc static analysis
@@ -414,18 +414,18 @@
'dartium']).indexOf(config['runtime']) >= 0;
}
if (!isValid) {
- print("Warning: combination of ${config['compiler']} and " +
+ print("Warning: combination of ${config['compiler']} and "
"${config['runtime']} is invalid. Skipping this combination.");
}
if (config['runtime'] == 'ie' &&
Platform.operatingSystem != 'windows') {
isValid = false;
- print("Warning cannot run Internet Explorer on non-Windows operating" +
+ print("Warning cannot run Internet Explorer on non-Windows operating"
" system.");
}
if (config['shard'] < 1 || config['shard'] > config['shards']) {
isValid = false;
- print("Error: shard index is ${config['shard']} out of " +
+ print("Error: shard index is ${config['shard']} out of "
"${config['shards']} shards");
}
if (config['runtime'] == 'dartium' && config['compiler'] == 'none' &&
@@ -500,7 +500,7 @@
pattern = ".*";
}
if (selectorMap.containsKey(suite)) {
- print("Error: '$suite/$pattern'. Only one test selection" +
+ print("Error: '$suite/$pattern'. Only one test selection"
" pattern is allowed to start with '$suite/'");
exit(1);
}

Powered by Google App Engine
This is Rietveld 408576698