Only emit typeguards if we think they are valuable.

Only emit typeguards if we think they are valuable.

Committed: https://code.google.com/p/dart/source/detail?r=6802

[floitsch, 2012-04-20 12:01:50]

I still need to update the tests.

[kasperl, 2012-04-20 12:07:31]

LGTM.

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/bailout.dart (right):

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/bailout.dart:116: bool isMoreNested(HBasicBlock
loopHeader1, HBasicBlock loopHeader2) {
isNestedInside? You're checking if loop1 is inside loop2 right? Maybe call one
outer (loop2) and one inner (loop1)?

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/bailout.dart:117: if (loopHeader1 ==
loopHeader2) return false;
Is this a place where === makes sense?

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:448: HBasicBlock
getEnclosingLoopHeader() {
Maybe drop the 'get' prefix?

[floitsch, 2012-04-20 12:43:47]

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/bailout.dart (right):

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/bailout.dart:116: bool isMoreNested(HBasicBlock
loopHeader1, HBasicBlock loopHeader2) {
On 2012/04/20 12:07:31, kasperl wrote:
> isNestedInside? You're checking if loop1 is inside loop2 right? Maybe call one
> outer (loop2) and one inner (loop1)?

Done.

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/bailout.dart:117: if (loopHeader1 ==
loopHeader2) return false;
On 2012/04/20 12:07:31, kasperl wrote:
> Is this a place where === makes sense?

Done.

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:448: HBasicBlock
getEnclosingLoopHeader() {
On 2012/04/20 12:07:31, kasperl wrote:
> Maybe drop the 'get' prefix?

How would you know it's not just a field (like parentLoopHeader) then? Or do you
want me to make it a getter?

[kasperl, 2012-04-20 12:52:14]

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:448: HBasicBlock
getEnclosingLoopHeader() {
On 2012/04/20 12:43:47, floitsch wrote:
> On 2012/04/20 12:07:31, kasperl wrote:
> > Maybe drop the 'get' prefix?
> 
> How would you know it's not just a field (like parentLoopHeader) then? Or do
you
> want me to make it a getter?

Like I know hashCode() isn't a field :-)

[floitsch, 2012-04-20 13:51:21]

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10165004/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:448: HBasicBlock
getEnclosingLoopHeader() {
On 2012/04/20 12:52:14, kasperl wrote:
> On 2012/04/20 12:43:47, floitsch wrote:
> > On 2012/04/20 12:07:31, kasperl wrote:
> > > Maybe drop the 'get' prefix?
> > 
> > How would you know it's not just a field (like parentLoopHeader) then? Or do
> you
> > want me to make it a getter?
> 
> Like I know hashCode() isn't a field :-)

I let Nicolas decide: now it's a getter :)

[kasperl, 2012-04-23 05:37:55]

LGTM. Even better.