| OLD | NEW |
| 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 // Dart test program for testing arrays. | 4 // Dart test program for testing arrays. |
| 5 | 5 |
| 6 bar() => true; | 6 bar() => true; |
| 7 | 7 |
| 8 tata() => 1.5; | 8 tata() => 1.5; |
| 9 | 9 |
| 10 // The type propagation in Dart2Js wrongly took the intersection of all incoming | 10 // The type propagation in Dart2Js wrongly took the intersection of all incoming |
| 11 // types in a loop-phi. In this case the back-edge brought type 'number' which, | 11 // types in a loop-phi. In this case the back-edge brought type 'number' which, |
| 12 // combined with 'integer' (i = 0) was narrowed to 'integer'. As a result no | 12 // combined with 'integer' (i = 0) was narrowed to 'integer'. As a result no |
| 13 // check was inserted for the list access. | 13 // check was inserted for the list access. |
| 14 foo(a) { | 14 foo(a) { |
| 15 var i; | 15 var i; |
| 16 if (bar()) { | 16 for (int j = 0; j < 1; j++) { |
| 17 // t's desired type is conflicting. Once it is used as array receiver. And | 17 if (bar()) { |
| 18 // once as integer. The backward propagation thus can't decide. | 18 // t's desired type is conflicting. Once it is used as array receiver. And |
| 19 // The forward declaration, however, will assign type num. | 19 // once as integer. The backward propagation thus can't decide. |
| 20 var t = 0 + tata(); | 20 // The forward declaration, however, will assign type num. |
| 21 i = t; | 21 var t = 0 + tata(); |
| 22 if (!bar()) t[0]; | 22 i = t; |
| 23 } else { | 23 if (!bar()) t[0]; |
| 24 i = 0; | 24 } else { |
| 25 i = 0; |
| 26 } |
| 27 // The phi, combining the two 'i's must reach the conclusion that i is of |
| 28 // type num and therefore needs a check before accessing the array. |
| 29 a[i]; |
| 25 } | 30 } |
| 26 // The phi, combining the two 'i's must reach the conclusion that i is of | |
| 27 // type num and therefore needs a check before accessing the array. | |
| 28 a[i]; | |
| 29 } | 31 } |
| 30 | 32 |
| 31 main() { | 33 main() { |
| 32 Expect.throws(() => foo([1, 2])); | 34 Expect.throws(() => foo([1, 2])); |
| 33 } | 35 } |
| OLD | NEW |