Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: frog/tests/leg/src/TypeGuardUnuserTest.dart

Issue 10165004: Only emit typeguards if we think they are valuable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/tests/leg/src/GVNTest.dart ('k') | frog/tests/leg/src/TypeInferenceTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/tests/leg/src/TypeGuardUnuserTest.dart
diff --git a/frog/tests/leg/src/TypeGuardUnuserTest.dart b/frog/tests/leg/src/TypeGuardUnuserTest.dart
index 188685c3d0bff499de3fc396d8e7fb3233e09887..80864cf74bbdb42a85ff96612406020f936f53b1 100644
--- a/frog/tests/leg/src/TypeGuardUnuserTest.dart
+++ b/frog/tests/leg/src/TypeGuardUnuserTest.dart
@@ -29,6 +29,15 @@ foo(int param1, int param2) {
}
""";
+final String TEST_THREE_WITH_BAILOUT = @"""
+foo(int param1, int param2) {
+ var t;
+ for (int i = 0; i < 1; i++) {
+ t = 0 + param1 + param2;
+ }
+ return t;
+}
+""";
main() {
String generated = compile(TEST_ONE, 'foo');
@@ -46,6 +55,12 @@ main() {
generated = compile(TEST_THREE, 'foo');
regexp = new RegExp(getNumberTypeCheck('param1'));
+ Expect.isTrue(!regexp.hasMatch(generated));
+ regexp = new RegExp(getNumberTypeCheck('param2'));
+ Expect.isTrue(!regexp.hasMatch(generated));
+
+ generated = compile(TEST_THREE_WITH_BAILOUT, 'foo');
+ regexp = new RegExp(getNumberTypeCheck('param1'));
Expect.isTrue(regexp.hasMatch(generated));
regexp = new RegExp(getNumberTypeCheck('param2'));
Expect.isTrue(regexp.hasMatch(generated));
« no previous file with comments | « frog/tests/leg/src/GVNTest.dart ('k') | frog/tests/leg/src/TypeInferenceTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698