Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: tests/language/src/ListDoubleIndexInLoop2Test.dart

Issue 10165004: Only emit typeguards if we think they are valuable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/src/ListDoubleIndexInLoop2Test.dart
diff --git a/tests/language/src/ListDoubleIndexInLoop2Test.dart b/tests/language/src/ListDoubleIndexInLoop2Test.dart
index 2a0ebd7acc8371342c556b89a32e7bc403092e67..bf200467ead8dec7bc17782fe6b1eb62f8cbca55 100644
--- a/tests/language/src/ListDoubleIndexInLoop2Test.dart
+++ b/tests/language/src/ListDoubleIndexInLoop2Test.dart
@@ -13,19 +13,21 @@ tata() => 1.5;
// check was inserted for the list access.
foo(a) {
var i;
- if (bar()) {
- // t's desired type is conflicting. Once it is used as array receiver. And
- // once as integer. The backward propagation thus can't decide.
- // The forward declaration, however, will assign type num.
- var t = 0 + tata();
- i = t;
- if (!bar()) t[0];
- } else {
- i = 0;
+ for (int j = 0; j < 1; j++) {
+ if (bar()) {
+ // t's desired type is conflicting. Once it is used as array receiver. And
+ // once as integer. The backward propagation thus can't decide.
+ // The forward declaration, however, will assign type num.
+ var t = 0 + tata();
+ i = t;
+ if (!bar()) t[0];
+ } else {
+ i = 0;
+ }
+ // The phi, combining the two 'i's must reach the conclusion that i is of
+ // type num and therefore needs a check before accessing the array.
+ a[i];
}
- // The phi, combining the two 'i's must reach the conclusion that i is of
- // type num and therefore needs a check before accessing the array.
- a[i];
}
main() {
« no previous file with comments | « lib/compiler/implementation/ssa/nodes.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698