Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 10021048: Remove need to instantiate Platform and make methods static. (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)
Modified:
8 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove need to instantiate Platform and make methods static. This will require an update of the stable test binary. I will upload a new build when done with the review process. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6682

Patch Set 1 #

Patch Set 2 : Add stable test binaries. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -90 lines) Patch
M lib/compiler/implementation/lib/io.dart View 1 chunk +18 lines, -2 lines 0 comments Download
M runtime/bin/platform.dart View 2 chunks +7 lines, -12 lines 0 comments Download
M runtime/bin/platform_impl.dart View 2 chunks +6 lines, -8 lines 0 comments Download
M runtime/bin/process_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/src/io/DartStdIOPipeTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/src/io/DirectoryErrorTest.dart View 5 chunks +15 lines, -20 lines 0 comments Download
M tests/standalone/src/io/DirectoryTest.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/src/io/FileErrorTest.dart View 4 chunks +12 lines, -16 lines 0 comments Download
M tests/standalone/src/io/PlatformTest.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/standalone/src/io/ProcessTestUtil.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/testing/bin/linux/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/macos/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/windows/dart.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/dart/multitest.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/testing/dart/test_options.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M utils/compiler/build_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years, 8 months ago (2012-04-18 10:30:22 UTC) #1
Søren Gjesse
LGTM Looks mush nicer!
8 years, 8 months ago (2012-04-18 11:17:42 UTC) #2
Sean Eagan
Just wanted to point out that http://dartbug.com/1668 also mentions changing the Platform methods to getters ...
8 years, 8 months ago (2012-04-18 13:34:52 UTC) #3
Mads Ager (google)
8 years, 8 months ago (2012-04-18 14:11:53 UTC) #4
Thanks for the pointer Sean. I wasn't even aware of the bug because it was under
another category. I'll move it to Area-IO and consider if we should change these
to getters.

Powered by Google App Engine
This is Rietveld 408576698