Remove need to instantiate Platform and make methods static.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 236 matching lines @@
     return new TestOutputImpl(testCase, exitCode, timedOut,
       stdout, stderr, time);
   }
 
   String get result() =>
       hasCrashed ? CRASH : (hasTimedOut ? TIMEOUT : (hasFailed ? FAIL : PASS));
 
   bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
 
   bool get hasCrashed() {
-    if (new Platform().operatingSystem() == 'windows') {
+    if (Platform.operatingSystem() == 'windows') {
       if (exitCode != 0) {
         // Suppress some flaky errors that crash the VM.
         // TODO(sigmund,efortuna): remove this when bug 2124 gets fixed.
         for (String line in testCase.output.stdout) {
           if (line.startsWith('Kind:')) {
             if (!alreadyPrintedWarning) {
               print("WARNING: VM crashed: $line, exit code: $exitCode. "
                     " This is a fake pass!!");
               alreadyPrintedWarning = true;
             }
@@ skipping 17 matching lines @@
   bool get hasTimedOut() => timedOut;
 
   bool get didFail() {
     return (exitCode != 0 && !hasCrashed);
   }
 
   // Reverse result of a negative test.
   bool get hasFailed() {
     // TODO(efortuna): This is a total hack to keep our buildbots (more) green
     // while the VM team solves Issue 2124. Remove when issue is fixed.
-    if (new Platform().operatingSystem() == 'windows' && (exitCode == 253 ||
+    if (Platform.operatingSystem() == 'windows' && (exitCode == 253 ||
         exitCode == 3)) {
       for (String line in testCase.output.stdout) {
         if (line.startsWith('VM exited with signal 1073741819') ||
             line.startsWith('Kind:')) {
           if (!alreadyPrintedWarning) {
             print("WARNING: VM crashed: $line This is a fake pass!!");
             alreadyPrintedWarning = true;
           }
           return testCase.expectedOutcomes.iterator().next() == FAIL;
         }
@@ skipping 307 matching lines @@
   void start() {
     Expect.isFalse(testCase.expectedOutcomes.contains(SKIP));
     stdout = new List<String>();
     stderr = new List<String>();
     currentStep = 0;
     runCommand(testCase.commands[currentStep++], stepExitHandler);
   }
 
   void runCommand(Command command,
                   void exitHandler(int exitCode)) {
-    if (new Platform().operatingSystem() == 'windows') {
+    if (Platform.operatingSystem() == 'windows') {
       // Windows can't handle the first command if it is a .bat file or the like
       // with the slashes going the other direction.
       // TODO(efortuna): Remove this when fixed (Issue 1306).
       command.executable = command.executable.replaceAll('/', '\\');
     }
     process = new Process.start(command.executable, command.arguments);
     process.onExit = exitHandler;
     startTime = new Date.now();
     InputStream stdoutStream = process.stdout;
     InputStream stderrStream = process.stderr;
@@ skipping 287 matching lines @@
   }
 
   void _testListerDone() {
     _activeTestListers--;
     _checkDone();
   }
 
   String globalTemporaryDirectory() {
     if (_temporaryDirectory != null) return _temporaryDirectory;
 
-    if (new Platform().operatingSystem() == 'windows') {
+    if (Platform.operatingSystem() == 'windows') {
       throw new Exception(
           'Test suite requires temporary directory. Not supported on Windows.');
     }
     var tempDir = new Directory('');
     tempDir.createTempSync();
     _temporaryDirectory = tempDir.path;
     return _temporaryDirectory;
   }
 
   /**
@@ skipping 32 matching lines @@
           };
         }
       }
     }
   }
 
   /**
    * True if we are using a browser + platform combination that needs the
    * Selenium server jar.
    */
-  bool get _needsSelenium() => new Platform().operatingSystem() == 'macos' &&
+  bool get _needsSelenium() => Platform.operatingSystem() == 'macos' &&
       browserUsed == 'safari';
 
   /** True if the Selenium Server is ready to be used. */
   bool get _isSeleniumAvailable() => _seleniumServer != null ||
       _seleniumAlreadyRunning;
 
   /**
    * Restart all the processes that have been waiting/stopped for the server to
    * start up. If we just call this once we end up with a single-"threaded" run.
    */
   void resumeTesting() {
     for (int i = 0; i < _maxProcesses; i++) _tryRunTest();
   }
 
   /** Start the Selenium Server jar, if appropriate for this platform. */
   void _ensureSeleniumServerRunning() {
     if (!_isSeleniumAvailable && !_startingServer) {
       _startingServer = true;
 
       // Check to see if the jar was already running before the program started.
       String cmd = 'ps';
       var arg = ['aux'];
-      if (new Platform().operatingSystem() == 'windows') {
+      if (Platform.operatingSystem() == 'windows') {
         cmd = 'tasklist';
         arg.add('/v');
       }
       Process p = new Process.start(cmd, arg);
       final StringInputStream stdoutStringStream =
           new StringInputStream(p.stdout);
       stdoutStringStream.onLine = () {
         var line = stdoutStringStream.readLine();
         while (null != line) {
           if (const RegExp(@".*selenium-server-standalone.*").hasMatch(line)) {
@@ skipping 39 matching lines @@
     };
   }
 
   /**
    * For browser tests using Safari or Opera, we need to use the Selenium 1.0
    * Java server.
    */
   void _startSeleniumServer() {
     // Get the absolute path to the Selenium jar.
     String filePath = new Options().script;
-    String pathSep = new Platform().pathSeparator();
+    String pathSep = Platform.pathSeparator();
     int index = filePath.lastIndexOf(pathSep);
     filePath = filePath.substring(0, index) + '${pathSep}testing${pathSep}';
     var dir = new Directory(filePath);
     dir.onFile = (String file) {
       if (const RegExp(@"selenium-server-standalone-.*\.jar").hasMatch(file)
           && _seleniumServer == null) {
         _seleniumServer = new Process.start('java', ['-jar', file]);
         // Heads up: there seems to an obscure data race of some form in
         // the VM between launching the server process and launching the test
         // tasks that disappears when you read IO (which is convenient, since
@@ skipping 82 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }