Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: runtime/bin/platform_impl.dart

Issue 10021048: Remove need to instantiate Platform and make methods static. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add stable test binaries. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/platform.dart ('k') | runtime/bin/process_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/platform_impl.dart
diff --git a/runtime/bin/platform_impl.dart b/runtime/bin/platform_impl.dart
index 46f041370ee0ef805a63b622c6f300ffd2981a7f..05f56db54376d84fecba0de1a8bbebe680aed122 100644
--- a/runtime/bin/platform_impl.dart
+++ b/runtime/bin/platform_impl.dart
@@ -2,28 +2,26 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-class _Platform implements Platform {
- _Platform();
-
+class _Platform {
static int _numberOfProcessors() native "Platform_NumberOfProcessors";
static String _pathSeparator() native "Platform_PathSeparator";
static String _operatingSystem() native "Platform_OperatingSystem";
static _localHostname() native "Platform_LocalHostname";
static _environment() native "Platform_Environment";
- int numberOfProcessors() {
+ static int numberOfProcessors() {
return _numberOfProcessors();
}
- String pathSeparator() {
+ static String pathSeparator() {
return _pathSeparator();
}
- String operatingSystem() {
+ static String operatingSystem() {
return _operatingSystem();
}
- String localHostname() {
+ static String localHostname() {
var result = _localHostname();
if (result is OSError) {
throw result;
@@ -32,7 +30,7 @@ class _Platform implements Platform {
}
}
- Map<String, String> environment() {
+ static Map<String, String> environment() {
var env = _environment();
if (env is OSError) {
throw env;
« no previous file with comments | « runtime/bin/platform.dart ('k') | runtime/bin/process_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698