Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/testing/dart/multitest.dart

Issue 10021048: Remove need to instantiate Platform and make methods static. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add stable test binaries. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/bin/windows/dart.exe ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/multitest.dart
diff --git a/tools/testing/dart/multitest.dart b/tools/testing/dart/multitest.dart
index 3bb4b8f6a1eb3b49d1527880cbde16e4dd95da10..6c2f84281e291ca1872645739a1104cda11ba8d1 100644
--- a/tools/testing/dart/multitest.dart
+++ b/tools/testing/dart/multitest.dart
@@ -1,4 +1,4 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -155,7 +155,7 @@ class _Annotation {
Set<String> _findAllRelativeImports(String topLibrary) {
Set<String> toSearch = new Set<String>.from([topLibrary]);
Set<String> foundImports = new HashSet<String>();
- String pathSep = new Platform().pathSeparator();
+ String pathSep = Platform.pathSeparator();
int end = topLibrary.lastIndexOf(pathSep);
String libraryDir = topLibrary.substring(0, end);
@@ -209,7 +209,7 @@ void DoMultitest(String filename,
String directory = CreateMultitestDirectory(outputDir, testDir);
Expect.isNotNull(directory);
- String pathSep = new Platform().pathSeparator();
+ String pathSep = Platform.pathSeparator();
int start = filename.lastIndexOf(pathSep) + 1;
int end = filename.indexOf('.dart', start);
String baseFilename = filename.substring(start, end);
« no previous file with comments | « tools/testing/bin/windows/dart.exe ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698