Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6778)

Unified Diff: chrome/browser/ui/gtk/first_run_bubble.cc

Issue 9969141: Add FirstRun.SearchEngineBubble UMA histogram counts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add and use first_run::LogFirstRunMetric; fix UMA macro. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/first_run_bubble_controller.mm ('k') | chrome/browser/ui/views/first_run_bubble.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/first_run_bubble.cc
diff --git a/chrome/browser/ui/gtk/first_run_bubble.cc b/chrome/browser/ui/gtk/first_run_bubble.cc
index d1bbeb6739a65b06cd3b7b9d19a7a363e0d12aaf..d96736f1b838da905cc45810a20b7380fde9d58b 100644
--- a/chrome/browser/ui/gtk/first_run_bubble.cc
+++ b/chrome/browser/ui/gtk/first_run_bubble.cc
@@ -8,6 +8,7 @@
#include "base/i18n/rtl.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/search_engines/util.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/gtk/theme_service_gtk.h"
@@ -31,6 +32,8 @@ const int kInterLineSpacing = 5;
void FirstRunBubble::Show(Profile* profile,
GtkWidget* anchor,
const gfx::Rect& rect) {
+ first_run::LogFirstRunMetric(first_run::FIRST_RUN_BUBBLE_SHOWN);
+
new FirstRunBubble(profile, anchor, rect);
}
@@ -83,6 +86,8 @@ void FirstRunBubble::HandleDestroy(GtkWidget* sender) {
}
void FirstRunBubble::HandleChangeLink(GtkWidget* sender) {
+ first_run::LogFirstRunMetric(first_run::FIRST_RUN_BUBBLE_CHANGE_INVOKED);
+
// Get |profile_|'s browser before closing the bubble, which deletes |this|.
Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
bubble_->Close();
« no previous file with comments | « chrome/browser/ui/cocoa/first_run_bubble_controller.mm ('k') | chrome/browser/ui/views/first_run_bubble.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698