Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 9969106: Revert 103073 - Scroll non-visible edit controls and caret into the center of the view when startin… (Closed)

Created:
8 years, 8 months ago by mnaganov (inactive)
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Revert 103073 - Scroll non-visible edit controls and caret into the center of the view when starting typing. https://bugs.webkit.org/show_bug.cgi?id=65027 Reviewed by Ryosuke Niwa. Tests: editing/input/caret-at-the-edge-of-contenteditable.html editing/input/caret-at-the-edge-of-input.html editing/input/reveal-caret-of-multiline-contenteditable.html editing/input/reveal-caret-of-multiline-input.html editing/input/reveal-contenteditable-on-input-vertically.html editing/input/reveal-contenteditable-on-paste-vertically.html editing/input/reveal-edit-on-input-vertically.html editing/input/reveal-edit-on-paste-vertically.html * editing/Editor.cpp: (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::revealSelectionAfterEditingOperation): * editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added. * editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added. * editing/input/caret-at-the-edge-of-contenteditable.html: Added. * editing/input/caret-at-the-edge-of-input-expected.png: Added. * editing/input/caret-at-the-edge-of-input-expected.txt: Added. * editing/input/caret-at-the-edge-of-input.html: Added. * editing/input/resources/reveal-utilities.js: Added. * editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added. * editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added. * editing/input/reveal-caret-of-multiline-contenteditable.html: Added. * editing/input/reveal-caret-of-multiline-input-expected.png: Added. * editing/input/reveal-caret-of-multiline-input-expected.txt: Added. * editing/input/reveal-caret-of-multiline-input.html: Added. * editing/input/reveal-contenteditable-on-input-vertically-expected.txt: Added. * editing/input/reveal-contenteditable-on-input-vertically.html: Added. * editing/input/reveal-contenteditable-on-paste-vertically-expected.txt: Added. * editing/input/reveal-contenteditable-on-paste-vertically.html: Added. * editing/input/reveal-edit-on-input-vertically-expected.txt: Added. * editing/input/reveal-edit-on-input-vertically.html: Added. * editing/input/reveal-edit-on-paste-vertically-expected.txt: Added. * editing/input/reveal-edit-on-paste-vertically.html: Added. * platform/chromium/test_expectations.txt: Mark new tests as FAIL to grab results from bots. * platform/gtk/test_expectations.txt: Mark new tests as FAIL to grab results from bots. * platform/qt/test_expectations.txt: Mark new tests as FAIL to grab results from bots. * platform/win/test_expectations.txt: Mark new tests as FAIL to grab results from bots. TBR=mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=113050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -274 lines) Patch
D LayoutTests/editing/input/caret-at-the-edge-of-contenteditable.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/editing/input/caret-at-the-edge-of-input.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/editing/input/resources/reveal-utilities.js View 1 chunk +0 lines, -66 lines 0 comments Download
D LayoutTests/editing/input/reveal-caret-of-multiline-contenteditable.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/editing/input/reveal-caret-of-multiline-input.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/editing/input/reveal-contenteditable-on-input-vertically.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/editing/input/reveal-contenteditable-on-input-vertically-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/editing/input/reveal-contenteditable-on-paste-vertically.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/editing/input/reveal-contenteditable-on-paste-vertically-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/editing/input/reveal-edit-on-input-vertically.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/editing/input/reveal-edit-on-input-vertically-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/editing/input/reveal-edit-on-paste-vertically.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/editing/input/reveal-edit-on-paste-vertically-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/editing/Editor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mnaganov (inactive)
8 years, 8 months ago (2012-04-03 16:59:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698