Source/WebCore/editing/Editor.cpp - Issue 9969106: Revert 103073 - Scroll non-visible edit controls and caret into the center of the view when startin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/editing/Editor.cpp

Issue 9969106: Revert 103073 - Scroll non-visible edit controls and caret into the center of the view when startin… (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1084/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/editing/Editor.cpp

===================================================================

--- Source/WebCore/editing/Editor.cpp (revision 113049)

+++ Source/WebCore/editing/Editor.cpp (working copy)

@@ -916,7 +916,7 @@

// Reveal the current selection

if (Frame* editedFrame = document->frame())

if (Page* page = editedFrame->page())

- page->focusController()->focusedOrMainFrame()->selection()->revealSelection(ScrollAlignment::alignCenterIfNeeded);

+ page->focusController()->focusedOrMainFrame()->selection()->revealSelection(ScrollAlignment::alignToEdgeIfNeeded);

}

@@ -2255,7 +2255,7 @@

if (m_ignoreCompositionSelectionChange)

return;

- m_frame->selection()->revealSelection(ScrollAlignment::alignCenterIfNeeded);

+ m_frame->selection()->revealSelection(ScrollAlignment::alignToEdgeIfNeeded);

}

void Editor::setIgnoreCompositionSelectionChange(bool ignore)

« no previous file with comments | « LayoutTests/editing/input/reveal-edit-on-paste-vertically-expected.txt ('k') | no next file » | no next file with comments »