chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc - Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove extraneous logging Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller_unittest.mm ('K') | « chrome/browser/ui/panels/panel_browsertest.cc ('k') | chrome/browser/ui/webui/chromeos/active_downloads_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

diff --git a/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc b/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

index 73ff97e34345a1aaed9461cb87c0ab136c961243..ed93c8c2d642668d1c55bb10bfb28813d7817768 100644

--- a/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

+++ b/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

@@ -77,10 +77,10 @@ class LauncherFaviconLoaderBrowsertest : public InProcessBrowserTest {

}

void CreatePanelBrowser(const char* url, Browser** result) {

- Browser* panel_browser = Browser::CreateForApp(Browser::TYPE_PANEL,

- "Test Panel",

- gfx::Rect(),

- browser()->profile());

+ Browser* panel_browser = Browser::CreateWithParams(

+ Browser::CreateParams::CreateForApp(

+ Browser::TYPE_PANEL, "Test Panel", gfx::Rect(),

+ browser()->profile()));

EXPECT_TRUE(panel_browser->is_type_panel());

ASSERT_EQ(static_cast<void*>(NULL), contents_observer_.get());

// Load initial tab contents before setting the observer.