chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm - Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove extraneous logging Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/browser_tab_restore_service_delegate.cc ('k') | chrome/browser/ui/cocoa/browser_window_controller_unittest.mm » ('j') | chrome/browser/ui/cocoa/browser_window_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

diff --git a/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm b/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

index f965d5491081cc3f2cc4c4bcbfc0461da6ae12ea..8ca34dc80c0fbac952944a22ecae50333058c7d6 100644

--- a/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

+++ b/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

@@ -20,9 +20,11 @@ typedef InProcessBrowserTest BrowserCrApplicationAppleScriptTest;

IN_PROC_BROWSER_TEST_F(BrowserCrApplicationAppleScriptTest, Creation) {

// Create additional |Browser*| objects of different type.

Profile* profile = browser()->profile();

- Browser* b1 = Browser::CreateForType(Browser::TYPE_POPUP, profile);

- Browser* b2 = Browser::CreateForApp(Browser::TYPE_PANEL, "Test",

- gfx::Rect(), profile);

+ Browser* b1 = Browser::CreateWithParams(

+ Browser::CreateParams(Browser::TYPE_POPUP, profile));

+ Browser* b2 = Browser::CreateWithParams(

+ Browser::CreateParams::CreateForApp(

+ Browser::TYPE_PANEL, "Test", gfx::Rect(), profile));

EXPECT_EQ(3U, [[NSApp appleScriptWindows] count]);

for (WindowAppleScript* window in [NSApp appleScriptWindows]) {