Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: chrome/browser/extensions/extension_tabs_test.cc

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extraneous logging Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_test.cc
diff --git a/chrome/browser/extensions/extension_tabs_test.cc b/chrome/browser/extensions/extension_tabs_test.cc
index 32879dad1bb24c369fcda5c8ba2801b484cc1c1b..58e2bb7d84e96278e07b66f5682cbf9ab2f88e58 100644
--- a/chrome/browser/extensions/extension_tabs_test.cc
+++ b/chrome/browser/extensions/extension_tabs_test.cc
@@ -84,8 +84,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, GetWindow) {
// minimize/maximize programmatically?
// Popup.
- Browser* popup_browser =
- Browser::CreateForType(Browser::TYPE_POPUP, browser()->profile());
+ Browser* popup_browser = Browser::CreateWithParams(
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
result.reset(utils::ToDictionary(
utils::RunFunctionAndReturnResult(
new GetWindowFunction(),
@@ -95,8 +95,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, GetWindow) {
EXPECT_EQ("popup", utils::GetString(result.get(), "type"));
// Panel.
- Browser* panel_browser =
- Browser::CreateForType(Browser::TYPE_PANEL, browser()->profile());
+ Browser* panel_browser = Browser::CreateWithParams(
+ Browser::CreateParams(Browser::TYPE_PANEL, browser()->profile()));
result.reset(utils::ToDictionary(
utils::RunFunctionAndReturnResult(
new GetWindowFunction(),
@@ -476,8 +476,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DontCreateTabInClosingPopupWindow) {
// Test creates new popup window, closes it right away and then tries to open
// a new tab in it. Tab should not be opened in the popup window, but in a
// tabbed browser window.
- Browser* popup_browser =
- Browser::CreateForType(Browser::TYPE_POPUP, browser()->profile());
+ Browser* popup_browser = Browser::CreateWithParams(
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
int window_id = ExtensionTabUtil::GetWindowId(popup_browser);
popup_browser->CloseWindow();

Powered by Google App Engine
This is Rietveld 408576698