Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: lib/dom/templates/html/impl/impl_Element.darttemplate

Issue 9963029: Fix some warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reupload (due to error messages during upload) Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/lib/dom/templates/html/impl/impl_Element.darttemplate b/lib/dom/templates/html/impl/impl_Element.darttemplate
index 95d62620845e54de424736e8844427cdcb054050..a53ab0001f1a62d4f164e55211632d6ae1be165c 100644
--- a/lib/dom/templates/html/impl/impl_Element.darttemplate
+++ b/lib/dom/templates/html/impl/impl_Element.darttemplate
@@ -111,20 +111,20 @@ class _ChildrenElementList implements ElementList {
throw 'Not impl yet. todo(jacobr)';
}
- void setRange(int start, int length, List from, [int startFrom = 0]) {
+ void setRange(int start, int rangeLength, List from, [int startFrom = 0]) {
throw const NotImplementedException();
}
- void removeRange(int start, int length) {
+ void removeRange(int start, int rangeLength) {
throw const NotImplementedException();
}
- void insertRange(int start, int length, [initialValue = null]) {
+ void insertRange(int start, int rangeLength, [initialValue = null]) {
throw const NotImplementedException();
}
- List getRange(int start, int length) =>
- new _FrozenElementList._wrap(_Lists.getRange(this, start, length,
+ List getRange(int start, int rangeLength) =>
+ new _FrozenElementList._wrap(_Lists.getRange(this, start, rangeLength,
<Element>[]));
int indexOf(Element element, [int start = 0]) {
@@ -142,11 +142,11 @@ class _ChildrenElementList implements ElementList {
}
Element removeLast() {
- final last = this.last();
- if (last != null) {
- _element.$dom_removeChild(last);
+ final result = this.last();
+ if (result != null) {
+ _element.$dom_removeChild(result);
}
- return last;
+ return result;
}
Element last() {
@@ -239,20 +239,20 @@ class _FrozenElementList implements ElementList {
throw const UnsupportedOperationException('');
}
- void setRange(int start, int length, List from, [int startFrom = 0]) {
+ void setRange(int start, int rangeLength, List from, [int startFrom = 0]) {
throw const UnsupportedOperationException('');
}
- void removeRange(int start, int length) {
+ void removeRange(int start, int rangeLength) {
throw const UnsupportedOperationException('');
}
- void insertRange(int start, int length, [initialValue = null]) {
+ void insertRange(int start, int rangeLength, [initialValue = null]) {
throw const UnsupportedOperationException('');
}
- ElementList getRange(int start, int length) =>
- new _FrozenElementList._wrap(_nodeList.getRange(start, length));
+ ElementList getRange(int start, int rangeLength) =>
+ new _FrozenElementList._wrap(_nodeList.getRange(start, rangeLength));
int indexOf(Element element, [int start = 0]) =>
_nodeList.indexOf(element, start);
@@ -301,8 +301,8 @@ class _ElementList extends _ListWrapper<Element> implements ElementList {
ElementList filter(bool f(Element element)) =>
new _ElementList(super.filter(f));
- ElementList getRange(int start, int length) =>
- new _ElementList(super.getRange(start, length));
+ ElementList getRange(int start, int rangeLength) =>
+ new _ElementList(super.getRange(start, rangeLength));
}
class _ElementAttributeMap implements AttributeMap {
« no previous file with comments | « lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate ('k') | lib/dom/templates/html/impl/impl_Node.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698