Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: lib/dom/templates/html/impl/impl_Node.darttemplate

Issue 9963029: Fix some warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reupload (due to error messages during upload) Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/templates/html/impl/impl_Node.darttemplate
diff --git a/lib/dom/templates/html/impl/impl_Node.darttemplate b/lib/dom/templates/html/impl/impl_Node.darttemplate
index 9295a1ee8ad470d1832ca545828d918e91951796..032c5570fe9985cd988f2b1dcd09654bd5df43d5 100644
--- a/lib/dom/templates/html/impl/impl_Node.darttemplate
+++ b/lib/dom/templates/html/impl/impl_Node.darttemplate
@@ -37,11 +37,11 @@ $endif
}
_NodeImpl removeLast() {
- final last = last();
- if (last != null) {
- _this.$dom_removeChild(last);
+ final result = last();
+ if (result != null) {
+ _this.$dom_removeChild(result);
}
- return last;
+ return result;
}
void clear() {
@@ -83,21 +83,21 @@ $endif
int lastIndexOf(Node element, [int start = 0]) =>
_Lists.lastIndexOf(this, element, start);
- // FIXME: implement thesee.
- void setRange(int start, int length, List<Node> from, [int startFrom]) {
+ // FIXME: implement these.
+ void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
throw new UnsupportedOperationException(
"Cannot setRange on immutable List.");
}
- void removeRange(int start, int length) {
+ void removeRange(int start, int rangeLength) {
throw new UnsupportedOperationException(
"Cannot removeRange on immutable List.");
}
- void insertRange(int start, int length, [Node initialValue]) {
+ void insertRange(int start, int rangeLength, [Node initialValue]) {
throw new UnsupportedOperationException(
"Cannot insertRange on immutable List.");
}
- NodeList getRange(int start, int length) =>
- new _NodeListWrapper(_Lists.getRange(this, start, length, <Node>[]));
+ NodeList getRange(int start, int rangeLength) =>
+ new _NodeListWrapper(_Lists.getRange(this, start, rangeLength, <Node>[]));
// -- end List<Node> mixins.
« no previous file with comments | « lib/dom/templates/html/impl/impl_Element.darttemplate ('k') | lib/dom/templates/html/impl/impl_NodeList.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698