Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate

Issue 9963029: Fix some warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reupload (due to error messages during upload) Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate
diff --git a/lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate b/lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate
index 00639971d59be0d11866b1fbe96ca7db6d56206f..cbe9afd3aedfe1298a90a30f85759e7760fa5b91 100644
--- a/lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate
+++ b/lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate
@@ -64,15 +64,15 @@ class FilteredElementList implements ElementList {
throw const NotImplementedException();
}
- void setRange(int start, int length, List from, [int startFrom = 0]) {
+ void setRange(int start, int rangeLength, List from, [int startFrom = 0]) {
throw const NotImplementedException();
}
- void removeRange(int start, int length) {
- _filtered.getRange(start, length).forEach((el) => el.remove());
+ void removeRange(int start, int rangeLength) {
+ _filtered.getRange(start, rangeLength).forEach((el) => el.remove());
}
- void insertRange(int start, int length, [initialValue = null]) {
+ void insertRange(int start, int rangeLength, [initialValue = null]) {
throw const NotImplementedException();
}
@@ -83,11 +83,11 @@ class FilteredElementList implements ElementList {
}
Element removeLast() {
- final last = this.last();
- if (last != null) {
- last.remove();
+ final result = this.last();
+ if (result != null) {
+ result.remove();
}
- return last;
+ return result;
}
Collection map(f(Element element)) => _filtered.map(f);
@@ -98,8 +98,8 @@ class FilteredElementList implements ElementList {
int get length() => _filtered.length;
Element operator [](int index) => _filtered[index];
Iterator<Element> iterator() => _filtered.iterator();
- List<Element> getRange(int start, int length) =>
- _filtered.getRange(start, length);
+ List<Element> getRange(int start, int rangeLength) =>
+ _filtered.getRange(start, rangeLength);
int indexOf(Element element, [int start = 0]) =>
_filtered.indexOf(element, start);
« no previous file with comments | « lib/dom/templates/html/frog/impl_EventTarget.darttemplate ('k') | lib/dom/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698