Issue 9963029: Fix some warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9963029: Fix some warnings. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang), Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix some warnings. Partially fixes Issue 2142 Committed: https://code.google.com/p/dart/source/detail?r=6119

Patch Set 1 #

Patch Set 2 : More fixes. #

Patch Set 3 : Reupload #

Patch Set 4 : Undo spurious change. #

Patch Set 5 : Reupload #

Patch Set 6 : Reupload (due to error messages during upload) #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+413 lines, -398 lines)			Patch
M	frog/lib/corelib_impl.dart	View		3 chunks	+29 lines, -27 lines	0 comments	Download
M	frog/lib/date_implementation.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	frog/lib/string_implementation.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	1	15 chunks	+90 lines, -90 lines	0 comments	Download
M	lib/dom/templates/html/frog/impl_EventTarget.darttemplate	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate	View	1	3 chunks	+10 lines, -10 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_Element.darttemplate	View	1	4 chunks	+16 lines, -16 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_Node.darttemplate	View	1	2 chunks	+10 lines, -10 lines	0 comments	Download
M	lib/dom/templates/html/impl/impl_NodeList.darttemplate	View	1	4 chunks	+19 lines, -17 lines	0 comments	Download
	lib/dom/templates/html/impl/impl_SVGElement.darttemplate	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	lib/dom/templates/immutable_list_mixin.darttemplate	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		14 chunks	+59 lines, -57 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View	1	30 chunks	+145 lines, -143 lines	0 comments	Download
M	lib/isolate/frog/isolateimpl.dart	View	1	8 chunks	+14 lines, -10 lines	0 comments	Download
M	lib/isolate/frog/ports.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/utf/utf_core.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages