components/favicon/core/BUILD.gn - Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/BUILD.gn

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup; moving defensive code into FallbackIconSource and LargeIconSource. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon/core/BUILD.gn

diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn

index bbda145967adfcebea8d848acfbac375a5298e59..8a4a0f740d034af303af1a9c8782b083f97df587 100644

--- a/components/favicon/core/BUILD.gn

+++ b/components/favicon/core/BUILD.gn

@@ -4,6 +4,7 @@

static_library("core") {

sources = [

+ "fallback_icon_client.h",

"fallback_icon_service.cc",

"fallback_icon_service.h",

"favicon_client.h",

« chrome/browser/ui/webui/large_icon_source.cc ('K') | « components/favicon.gypi ('k') | components/favicon/core/DEPS » ('j') | components/favicon/core/fallback_icon_client.h » ('J')