components/favicon/core/BUILD.gn - Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/favicon/core/BUILD.gn

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup; moving defensive code into FallbackIconSource and LargeIconSource. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("core") {	5 static_library("core") {

6 sources = [	6 sources = [

	7 "fallback_icon_client.h",

7 "fallback_icon_service.cc",	8 "fallback_icon_service.cc",

8 "fallback_icon_service.h",	9 "fallback_icon_service.h",

9 "favicon_client.h",	10 "favicon_client.h",

10 "favicon_driver.h",	11 "favicon_driver.h",

11 "favicon_handler.cc",	12 "favicon_handler.cc",

12 "favicon_handler.h",	13 "favicon_handler.h",

13 "favicon_service.cc",	14 "favicon_service.cc",

14 "favicon_service.h",	15 "favicon_service.h",

15 "favicon_tab_helper_observer.h",	16 "favicon_tab_helper_observer.h",

16 "favicon_url.cc",	17 "favicon_url.cc",

17 "favicon_url.h",	18 "favicon_url.h",

18 ]	19 ]

19	20

20 deps = [	21 deps = [

21 "//components/bookmarks/browser",	22 "//components/bookmarks/browser",

22 "//components/favicon_base",	23 "//components/favicon_base",

23 "//components/history/core/browser",	24 "//components/history/core/browser",

24 "//components/keyed_service/core",	25 "//components/keyed_service/core",

25 "//skia",	26 "//skia",

26 "//ui/gfx",	27 "//ui/gfx",

27 "//url",	28 "//url",

28 ]	29 ]

29 }	30 }

OLD	NEW

« chrome/browser/ui/webui/large_icon_source.cc ('K') | « components/favicon.gypi ('k') | components/favicon/core/DEPS » ('j') | components/favicon/core/fallback_icon_client.h » ('J')