components/favicon.gypi - Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon.gypi

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup; moving defensive code into FallbackIconSource and LargeIconSource. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/large_icon_source.cc ('K') | « chrome/test/base/testing_profile.cc ('k') | components/favicon/core/BUILD.gn » ('j') | components/favicon/core/fallback_icon_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/favicon.gypi

diff --git a/components/favicon.gypi b/components/favicon.gypi

index cddc7465578a7e87731759df133661b33b2e6ada..8a9378bdf06a8f90608229f884257bcf5cf6ea30 100644

--- a/components/favicon.gypi

+++ b/components/favicon.gypi

@@ -19,6 +19,7 @@

'sources': [

# Note: sources list duplicated in GN build.

+ 'favicon/core/fallback_icon_client.h',

'favicon/core/fallback_icon_service.cc',

'favicon/core/fallback_icon_service.h',

'favicon/core/favicon_client.h',