Issue 9960046: Merge 130848 - Add FirstRun.SearchEngineBubble UMA histogram counts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9960046: Merge 130848 - Add FirstRun.SearchEngineBubble UMA histogram counts. (Closed)

Created:
8 years, 8 months ago by msw

Modified:
8 years, 8 months ago

Reviewers:
msw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

More Reviews

Description

Merge 130848 - Add FirstRun.SearchEngineBubble UMA histogram counts. Add an enum for first run bubble histogram counts. Add first_run::LogFirstRunMetric utility function. Log metrics for actions of interest (show and 'Change'). This change depends on the src-internal change (4219017). BUG=121782 TEST=New histogram data available for first run bubble impressions and use. Review URL: http://codereview.chromium.org/9969141 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131445

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -0 lines)			Patch
M	chrome/browser/first_run/first_run.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/first_run/first_run.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/first_run_bubble_controller.mm	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/first_run_bubble.cc	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/first_run_bubble.cc	View	3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages