chrome/browser/ui/cocoa/first_run_bubble_controller.mm - Issue 9960046: Merge 130848 - Add FirstRun.SearchEngineBubble UMA histogram counts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/first_run_bubble_controller.mm

Issue 9960046: Merge 130848 - Add FirstRun.SearchEngineBubble UMA histogram counts. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1084/src/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/first_run_bubble_controller.mm

===================================================================

--- chrome/browser/ui/cocoa/first_run_bubble_controller.mm (revision 131444)

+++ chrome/browser/ui/cocoa/first_run_bubble_controller.mm (working copy)

@@ -6,6 +6,7 @@

#include "base/logging.h"

#include "base/utf_string_conversions.h"

+#include "chrome/browser/first_run/first_run.h"

#include "chrome/browser/search_engines/util.h"

#include "chrome/browser/ui/browser_list.h"

#import "chrome/browser/ui/cocoa/l10n_util.h"

@@ -51,6 +52,8 @@

}

- (void)awakeFromNib {

+ first_run::LogFirstRunMetric(first_run::FIRST_RUN_BUBBLE_SHOWN);

DCHECK(header_);

[header_ setStringValue:cocoa_l10n_util::ReplaceNSStringPlaceholders(

[header_ stringValue], GetDefaultSearchEngineName(profile_), NULL)];

@@ -81,6 +84,8 @@

}

- (IBAction)onChange:(id)sender {

+ first_run::LogFirstRunMetric(first_run::FIRST_RUN_BUBBLE_CHANGE_INVOKED);

Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);

[self close];

if (browser)

« no previous file with comments | « chrome/browser/first_run/first_run.cc ('k') | chrome/browser/ui/gtk/first_run_bubble.cc » ('j') | no next file with comments »