Issue 9959119: Revert 130442 - Adds a TabContentsViewAura.

Issue 9959119: Revert 130442 - Adds a TabContentsViewAura. (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov

Modified:
8 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ben+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 130442 - Adds a TabContentsViewAura. It is derived from TCVV/NTCVA. Right now, it's behind the flag --enable-tcva. http://crbug.com/118410 TEST=none Review URL: https://chromiumcodereview.appspot.com/9963079 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130455

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -1046 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	3 chunks	+8 lines, -19 lines	0 comments	Download
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_aura.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_aura.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.h	View	1 chunk	+0 lines, -66 lines	0 comments	Download
D	chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.cc	View	1 chunk	+0 lines, -181 lines	0 comments	Download
A +	chrome/browser/tab_contents/chrome_web_contents_view_delegate_win.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/tab_contents/chrome_web_contents_view_delegate_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
D	content/browser/tab_contents/tab_contents_view_aura.h	View	1 chunk	+0 lines, -143 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_view_aura.cc	View	1 chunk	+5 lines, -594 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/browser/web_contents_view_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/window.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 8 months ago (2012-04-03 21:15:43 UTC) #2

LGTM

On Tue, Apr 3, 2012 at 2:12 PM, <sergeyu@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Revert 130442 - Adds a TabContentsViewAura.
>
> It is derived from TCVV/NTCVA. Right now, it's behind the flag
> --enable-tcva.
>
> http://crbug.com/118410
> TEST=none
> Review URL:
https://chromiumcodereview.**appspot.com/9963079<https://chromiumcodereview.a...
>
> TBR=ben@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/9959119/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     chrome/browser/chrome_content_**browser_client.cc
>  M     chrome/browser/tab_contents/**chrome_web_contents_view_**
> delegate_aura.h
>  M     chrome/browser/tab_contents/**chrome_web_contents_view_**
> delegate_aura.cc
>  D     chrome/browser/tab_contents/**chrome_web_contents_view_**
> delegate_views.h
>  D     chrome/browser/tab_contents/**chrome_web_contents_view_**
> delegate_views.cc
>  A  +  chrome/browser/tab_contents/**chrome_web_contents_view_**
> delegate_win.h
>  A  +  chrome/browser/tab_contents/**chrome_web_contents_view_**
> delegate_win.cc
>  M     chrome/chrome_browser.gypi
>  M     chrome/common/chrome_switches.**h
>  M     chrome/common/chrome_switches.**cc
>  M     content/browser/tab_contents/**tab_contents.cc
>  D     content/browser/tab_contents/**tab_contents_view_aura.h
>  M     content/browser/tab_contents/**tab_contents_view_aura.cc
>  M     content/content_browser.gypi
>  M     content/public/browser/web_**contents_view_delegate.h
>  M     ui/aura/window.cc
>
>
>

Expand Messages | Collapse Messages