Issue 9963079: Adds a TabContentsViewAura.

Issue 9963079: Adds a TabContentsViewAura. (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)

Modified:
8 years, 8 months ago

Reviewers:
Josh Horwich, jam

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Adds a TabContentsViewAura. It is derived from TCVV/NTCVA. Right now, it's behind the flag --enable-tcva. http://crbug.com/118410 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130442 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130704

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+655 lines, -246 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1 2 3	3 chunks	+19 lines, -8 lines	0 comments	Download
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_aura.h	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_aura.cc	View	1 2 3	1 chunk	+16 lines, -0 lines	0 comments	Download
A +	chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.h	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.cc	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/tab_contents/chrome_web_contents_view_delegate_win.h	View	1 2 3	1 chunk	+0 lines, -65 lines	0 comments	Download
D	chrome/browser/tab_contents/chrome_web_contents_view_delegate_win.cc	View	1 2 3	1 chunk	+0 lines, -164 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
A +	content/browser/tab_contents/tab_contents_view_aura.h	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_view_aura.cc	View	1 2 3	1 chunk	+594 lines, -5 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/browser/web_contents_view_delegate.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/window.cc	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm, thanks for doing this http://codereview.chromium.org/9963079/diff/3017/chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.h File chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.h (right): http://codereview.chromium.org/9963079/diff/3017/chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.h#newcode19 chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.h:19: content::WebDragDestDelegate; did you mean ...

8 years, 8 months ago (2012-04-03 17:29:27 UTC) #2

Josh Horwich

Turns out the ChromeOS compilers run with -Werror=conversion-null, so the non-cast NULL broke on ChromiumOS. ...

8 years, 8 months ago (2012-04-03 21:34:59 UTC) #3

Ben Goodger (Google)

8 years, 8 months ago (2012-04-03 23:14:18 UTC) #4

Saw the revert. Oops. fwiw linux_chromeos try run was green.

-Ben

On Tue, Apr 3, 2012 at 2:34 PM, <jhorwich@chromium.org> wrote:

> Turns out the ChromeOS compilers run with -Werror=conversion-null, so the
> non-cast NULL broke on ChromiumOS. We had to revert this CL @ r130455 (Was
> going
> to just patch myself but took too long for uninteresting reasons).
>
>
> https://chromiumcodereview.**appspot.com/9963079/diff/7045/**
>
content/browser/tab_contents/**tab_contents_view_aura.cc<https://chromiumcodereview.appspot.com/9963079/diff/7045/content/browser/tab_contents/tab_contents_view_aura.cc>
> File content/browser/tab_contents/**tab_contents_view_aura.cc (right):
>
> https://chromiumcodereview.**appspot.com/9963079/diff/7045/**
>
content/browser/tab_contents/**tab_contents_view_aura.cc#**newcode496<https://chromiumcodereview.appspot.com/9963079/diff/7045/content/browser/tab_contents/tab_contents_view_aura.cc#newcode496>
> content/browser/tab_contents/**tab_contents_view_aura.cc:496: return NULL;
> gfx::kNullCursor
>
>
https://chromiumcodereview.**appspot.com/9963079/<https://chromiumcodereview....
>

Expand Messages | Collapse Messages