Issue 9958067: Fixing a bug in GRIT where messages with substitutions would

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9958067: Fixing a bug in GRIT where messages with substitutions would (Closed)

Created:
8 years, 8 months ago by Jói

Modified:
8 years, 8 months ago

Reviewers:
tony

CC:
grit-developer_googlegroups.com

Base URL:
https://grit-i18n.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fixing a bug in GRIT where messages with substitutions would not get matched with their translations. Also adding a catch-all so that messages containing only whitespace do not get sent to the Translation Console. Also, fix relative paths so unit tests can be run directly. This is a manual merge of changes released 2008/09/02 to the Google-internal version of grit. Original author Joi Sigurdsson. BUG=http://code.google.com/p/grit-i18n/issues/detail?id=4 Committed: https://code.google.com/p/grit-i18n/source/detail?r=30

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -16 lines)			Patch
M	grit/clique.py	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	grit/clique_unittest.py	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	grit/node/base.py	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	grit/node/misc.py	View	1 chunk	+19 lines, -4 lines	0 comments	Download
M	grit/test_suite_all.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	grit/testdata/substitute.grd	View	1 chunk	+31 lines, -0 lines	0 comments	Download
A	grit/testdata/substitute.xmb	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	grit/tool/build.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	grit/tool/build_unittest.py	View	1 chunk	+39 lines, -0 lines	0 comments	Download
M	grit/tool/postprocess_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	grit/tool/preprocess_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages