grit/tool/build.py - Issue 9958067: Fixing a bug in GRIT where messages with substitutions would

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: grit/tool/build.py

Issue 9958067: Fixing a bug in GRIT where messages with substitutions would (Closed) Base URL: https://grit-i18n.googlecode.com/svn/trunk

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 '''The 'grit build' tool along with integration for this tool with the	6 '''The 'grit build' tool along with integration for this tool with the

7 SCons build system.	7 SCons build system.

8 '''	8 '''

9	9

10 import filecmp	10 import filecmp

(...skipping 272 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
283 print '\n'.join(warnings)	283 print '\n'.join(warnings)

284	284

285 # Print out any fallback warnings, and missing translation errors, and	285 # Print out any fallback warnings, and missing translation errors, and

286 # exit with an error code if there are missing translations in a non-pseudo	286 # exit with an error code if there are missing translations in a non-pseudo

287 # and non-official build.	287 # and non-official build.

288 warnings = (self.res.UberClique().MissingTranslationsReport().	288 warnings = (self.res.UberClique().MissingTranslationsReport().

289 encode('ascii', 'replace'))	289 encode('ascii', 'replace'))

290 if warnings and self.defines.get('_google_chrome', False):	290 if warnings and self.defines.get('_google_chrome', False):

291 print warnings	291 print warnings

292 if self.res.UberClique().HasMissingTranslations():	292 if self.res.UberClique().HasMissingTranslations():

	293 print self.res.UberClique().missing_translations_

293 sys.exit(-1)	294 sys.exit(-1)

OLD	NEW

« no previous file with comments | « grit/testdata/substitute.xmb ('k') | grit/tool/build_unittest.py » ('j') | no next file with comments »