Support @NoInline for constructor bodies.

Support @NoInline for constructor bodies.

BUG=
R=floitsch@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44402

[herhut, 2015-03-10 16:46:30]

herhut@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-03-10 17:42:27]

LGTM, but wait for Johnni. (it is not really nice...)

https://chromiumcodereview.appspot.com/987393002/diff/1/pkg/compiler/lib/src/...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/987393002/diff/1/pkg/compiler/lib/src/...
pkg/compiler/lib/src/js_backend/backend.dart:52: // this cache from metadata
annotations, so look for their parent
missing ".".

https://chromiumcodereview.appspot.com/987393002/diff/1/pkg/compiler/lib/src/...
pkg/compiler/lib/src/js_backend/backend.dart:56: print("checked for $element as
$decision via ${body.constructor}");
remove print.

[Johnni Winther, 2015-03-11 08:27:52]

Please add (or expand) a unittest to check that constructor body is not inlined.

Otherwise LGTM.

https://chromiumcodereview.appspot.com/987393002/diff/1/tests/language/implic...
File tests/language/implicit_super_constructor_call_test.dart (left):

https://chromiumcodereview.appspot.com/987393002/diff/1/tests/language/implic...
tests/language/implicit_super_constructor_call_test.dart:12: @NoInline
This should be a compile-time error, but we unfortunately currently allow it.

[herhut, 2015-03-11 14:01:11]

Patchset #2 (id:20001) has been deleted

[herhut, 2015-03-11 14:01:56]

https://codereview.chromium.org/987393002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/987393002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/backend.dart:52: // this cache from metadata
annotations, so look for their parent
On 2015/03/10 17:42:27, floitsch wrote:
> missing ".".

Done.

https://codereview.chromium.org/987393002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/backend.dart:56: print("checked for $element as
$decision via ${body.constructor}");
On 2015/03/10 17:42:27, floitsch wrote:
> remove print.

Done.

https://codereview.chromium.org/987393002/diff/1/tests/language/implicit_supe...
File tests/language/implicit_super_constructor_call_test.dart (left):

https://codereview.chromium.org/987393002/diff/1/tests/language/implicit_supe...
tests/language/implicit_super_constructor_call_test.dart:12: @NoInline
On 2015/03/11 08:27:52, Johnni Winther wrote:
> This should be a compile-time error, but we unfortunately currently allow it.

Acknowledged.

[herhut, 2015-03-11 14:15:18]

Committed patchset #2 (id:40001) manually as 44402 (presubmit successful).